Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: `Process` finalizer should wait for process on Unix systems #18881

Open
ianlancetaylor opened this issue Feb 1, 2017 · 2 comments
Open

os: `Process` finalizer should wait for process on Unix systems #18881

ianlancetaylor opened this issue Feb 1, 2017 · 2 comments
Labels
Milestone

Comments

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Feb 1, 2017

The os package sets a finalizer on all Process values. Currently, on Unix, that finalizer does nothing useful. It should probably call wait on the process if that has not already been done, to remove the otherwise zombie process.

@ianlancetaylor ianlancetaylor added this to the Go1.9Maybe milestone Feb 1, 2017
@minux
Copy link
Member

@minux minux commented Feb 1, 2017

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Nov 30, 2017

Too late for Go 1.10, but I'd love to see this done by the runtime at some point. Zombie accumulation is one of my top 10 Go bugs. It's easy to diagnose and fix, but I wonder how many people don't do either.

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 30, 2017
@gopherbot gopherbot modified the milestones: Go1.11, Unplanned May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.