Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: documentation for CreateCertificateRequest extensions unclear #18899

Closed
lwithers opened this issue Feb 2, 2017 · 1 comment
Closed
Assignees
Milestone

Comments

@lwithers
Copy link

@lwithers lwithers commented Feb 2, 2017

In the documentation for the function x509.CreateCertificateRequest, the text states:

The following members of template are used: Subject, Attributes, SignatureAlgorithm, Extensions, DNSNames, EmailAddresses, and IPAddresses.

This implies that we read the CertificateRequest.Extensions field when creating the CSR, and that this would be the correct slice into which we place desired X509v3 extensions; however, this is inaccurate, since we actually only read the .ExtraExtensions field. The documentation should be altered to reflect this.

@bradfitz bradfitz added this to the Go1.9 milestone Feb 2, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 8, 2017

CL https://golang.org/cl/36558 mentions this issue.

@gopherbot gopherbot closed this in 7853b09 Feb 9, 2017
@golang golang locked and limited conversation to collaborators Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.