Skip to content

crypto/x509: documentation for CreateCertificateRequest extensions unclear #18899

Description

@lwithers

In the documentation for the function x509.CreateCertificateRequest, the text states:

The following members of template are used: Subject, Attributes, SignatureAlgorithm, Extensions, DNSNames, EmailAddresses, and IPAddresses.

This implies that we read the CertificateRequest.Extensions field when creating the CSR, and that this would be the correct slice into which we place desired X509v3 extensions; however, this is inaccurate, since we actually only read the .ExtraExtensions field. The documentation should be altered to reflect this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions