Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialTimeout flaky when compiling go1.4 #18954

Closed
choleraehyq opened this issue Feb 6, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@choleraehyq
Copy link
Contributor

commented Feb 6, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

I want to build go 1.4 to bootstrap higher version go.
I use go1.4-bootstrap-20161024.tar.gz.

What operating system and processor architecture are you using (go env)?

[cholerae@localhost ~]$ uname -r
4.9.7-201.fc25.x86_64
[cholerae@localhost src]$ lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                2
On-line CPU(s) list:   0,1
Thread(s) per core:    1
Core(s) per socket:    2
Socket(s):             1
NUMA node(s):          1
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 23
Model name:            Intel(R) Core(TM)2 Duo CPU     L9600  @ 2.13GHz
Stepping:              10
CPU MHz:               800.000
CPU max MHz:           2134.0000
CPU min MHz:           800.0000
BogoMIPS:              4256.12
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              6144K
NUMA node0 CPU(s):     0,1
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts nopl aperfmperf eagerfpu pni dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 xsave lahf_lm tpr_shadow vnmi flexpriority dtherm ida
[cholerae@localhost src]$ lsb_release -a
LSB Version:	:core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch
Distributor ID:	Fedora
Description:	Fedora release 25 (Twenty Five)
Release:	25
Codename:	TwentyFive
[cholerae@localhost src]$ gcc --version
gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

cd ./src
./all.bash

What did you expect to see?

Successfully compiled and all tests passed.

What did you see instead?

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
libbio
liblink
cmd/cc
cmd/gc
cmd/6l
cmd/6a
cmd/6c
/home/cholerae/Downloads/go/src/cmd/6c/txt.c: In function 'gmove':
/home/cholerae/Downloads/go/src/cmd/6c/txt.c:995:28: warning: left shift of negative value [-Wshift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
/home/cholerae/Downloads/go/src/cmd/6c/txt.c:1045:28: warning: left shift of negative value [-Wshift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
cmd/6g
runtime
errors
sync/atomic
sync
io
unicode
unicode/utf8
unicode/utf16
bytes
math
strings
strconv
bufio
sort
container/heap
encoding/base64
syscall
time
os
reflect
fmt
encoding
encoding/json
flag
path/filepath
path
io/ioutil
log
regexp/syntax
regexp
go/token
go/scanner
go/ast
go/parser
os/exec
os/signal
net/url
text/template/parse
text/template
go/doc
go/build
cmd/go

# Building packages and commands for linux/amd64.
runtime
errors
sync/atomic
unicode
sync
io
unicode/utf8
math
bytes
bufio
syscall
strconv
time
reflect
os
strings
fmt
encoding/binary
sort
regexp/syntax
cmd/internal/goobj
cmd/internal/rsc.io/arm/armasm
cmd/internal/rsc.io/x86/x86asm
debug/dwarf
debug/elf
debug/gosym
debug/macho
debug/pe
debug/plan9obj
regexp
text/tabwriter
flag
log
hash
crypto
cmd/internal/objfile
crypto/md5
go/token
path/filepath
go/scanner
cmd/addr2line
go/ast
io/ioutil
go/parser
go/printer
os/exec
path
container/heap
encoding
encoding/base64
unicode/utf16
encoding/json
cmd/cgo
go/format
cmd/fix
encoding/xml
net/url
text/template/parse
compress/flate
hash/crc32
compress/gzip
container/list
text/template
crypto/subtle
crypto/cipher
crypto/aes
crypto/des
math/rand
go/doc
math/big
go/build
crypto/elliptic
encoding/asn1
crypto/hmac
internal/syscall
crypto/rand
crypto/rc4
crypto/rsa
crypto/ecdsa
crypto/sha1
crypto/sha256
crypto/dsa
crypto/sha512
crypto/x509/pkix
encoding/hex
encoding/pem
runtime/cgo
mime
net/http/internal
os/signal
runtime/pprof
cmd/gofmt
net
cmd/nm
cmd/objdump
crypto/x509
crypto/tls
net/textproto
mime/multipart
cmd/pack
net/http
cmd/pprof/internal/profile
cmd/pprof/internal/plugin
html
cmd/go
html/template
cmd/pprof/internal/report
cmd/pprof/internal/svg
cmd/pprof/internal/tempfile
cmd/pprof/internal/commands
cmd/pprof/internal/driver
cmd/pprof/internal/fetch
cmd/pprof/internal/symbolizer
cmd/pprof/internal/symbolz
cmd/pprof
cmd/yacc
archive/tar
archive/zip
compress/bzip2
compress/lzw
hash/adler32
compress/zlib
container/ring
database/sql/driver
database/sql
encoding/ascii85
encoding/base32
encoding/csv
encoding/gob
expvar
hash/crc64
hash/fnv
image/color
image
image/color/palette
image/draw
image/jpeg
image/gif
image/png
index/suffixarray
log/syslog
math/cmplx
net/http/cgi
net/http/cookiejar
net/http/httptest
net/http/fcgi
net/http/httputil
net/http/pprof
net/mail
net/rpc
net/smtp
os/user
net/rpc/jsonrpc
runtime/debug
runtime/race
testing
testing/iotest
testing/quick
text/scanner

# Testing packages.
ok  	cmd/addr2line	0.729s
?   	cmd/cgo	[no test files]
ok  	cmd/fix	0.026s
ok  	cmd/go	0.013s
ok  	cmd/gofmt	0.084s
ok  	cmd/nm	0.793s
ok  	cmd/objdump	1.841s
ok  	cmd/pack	3.794s
?   	cmd/pprof	[no test files]
?   	cmd/yacc	[no test files]
ok  	archive/tar	0.021s
ok  	archive/zip	0.620s
ok  	bufio	0.175s
ok  	bytes	0.154s
ok  	cmd/internal/goobj	0.004s
?   	cmd/internal/objfile	[no test files]
?   	cmd/pprof/internal/commands	[no test files]
?   	cmd/pprof/internal/driver	[no test files]
?   	cmd/pprof/internal/fetch	[no test files]
?   	cmd/pprof/internal/plugin	[no test files]
?   	cmd/pprof/internal/profile	[no test files]
?   	cmd/pprof/internal/report	[no test files]
?   	cmd/pprof/internal/svg	[no test files]
?   	cmd/pprof/internal/symbolizer	[no test files]
?   	cmd/pprof/internal/symbolz	[no test files]
?   	cmd/pprof/internal/tempfile	[no test files]
ok  	compress/bzip2	0.094s
ok  	compress/flate	0.716s
ok  	compress/gzip	0.014s
ok  	compress/lzw	0.111s
ok  	compress/zlib	1.488s
ok  	container/heap	0.004s
ok  	container/list	0.003s
ok  	container/ring	0.018s
?   	crypto	[no test files]
ok  	crypto/aes	0.035s
ok  	crypto/cipher	0.005s
ok  	crypto/des	0.017s
ok  	crypto/dsa	0.008s
ok  	crypto/ecdsa	0.034s
ok  	crypto/elliptic	0.051s
ok  	crypto/hmac	0.004s
ok  	crypto/md5	0.005s
ok  	crypto/rand	0.032s
ok  	crypto/rc4	0.211s
ok  	crypto/rsa	0.208s
ok  	crypto/sha1	0.004s
ok  	crypto/sha256	0.007s
ok  	crypto/sha512	0.007s
ok  	crypto/subtle	0.011s
ok  	crypto/tls	2.017s
ok  	crypto/x509	1.487s
?   	crypto/x509/pkix	[no test files]
ok  	database/sql	0.053s
ok  	database/sql/driver	0.003s
ok  	debug/dwarf	0.024s
ok  	debug/elf	0.031s
ok  	debug/gosym	0.269s
ok  	debug/macho	0.006s
ok  	debug/pe	0.095s
ok  	debug/plan9obj	0.003s
?   	encoding	[no test files]
ok  	encoding/ascii85	0.005s
ok  	encoding/asn1	0.020s
ok  	encoding/base32	0.005s
ok  	encoding/base64	0.005s
ok  	encoding/binary	0.005s
ok  	encoding/csv	0.005s
ok  	encoding/gob	0.084s
ok  	encoding/hex	0.004s
ok  	encoding/json	0.252s
ok  	encoding/pem	0.007s
ok  	encoding/xml	0.019s
ok  	errors	0.004s
ok  	expvar	0.006s
ok  	flag	0.004s
ok  	fmt	0.056s
ok  	go/ast	0.007s
ok  	go/build	0.165s
ok  	go/doc	0.088s
ok  	go/format	0.012s
ok  	go/parser	0.043s
ok  	go/printer	0.437s
ok  	go/scanner	0.006s
ok  	go/token	0.043s
?   	hash	[no test files]
ok  	hash/adler32	0.011s
ok  	hash/crc32	0.004s
ok  	hash/crc64	0.004s
ok  	hash/fnv	0.003s
ok  	html	0.005s
ok  	html/template	0.057s
ok  	image	0.149s
ok  	image/color	0.011s
?   	image/color/palette	[no test files]
ok  	image/draw	0.104s
ok  	image/gif	0.081s
ok  	image/jpeg	0.278s
ok  	image/png	0.060s
ok  	index/suffixarray	0.021s
?   	internal/syscall	[no test files]
ok  	io	0.019s
ok  	io/ioutil	0.004s
ok  	log	0.008s
ok  	log/syslog	2.025s
ok  	math	0.005s
ok  	math/big	0.343s
ok  	math/cmplx	0.004s
ok  	math/rand	0.291s
ok  	mime	0.013s
ok  	mime/multipart	0.372s
--- FAIL: TestDialTimeout (0.02s)
	dial_test.go:100: all connections connected; expected some to time out
FAIL
FAIL	net	2.409s
ok  	net/http	7.730s
ok  	net/http/cgi	0.402s
ok  	net/http/cookiejar	0.010s
ok  	net/http/fcgi	0.007s
ok  	net/http/httptest	0.007s
ok  	net/http/httputil	0.015s
ok  	net/http/internal	0.004s
?   	net/http/pprof	[no test files]
ok  	net/mail	0.009s
ok  	net/rpc	0.021s
ok  	net/rpc/jsonrpc	0.011s
ok  	net/smtp	0.036s
ok  	net/textproto	0.006s
ok  	net/url	0.009s
ok  	os	0.622s
ok  	os/exec	0.249s
ok  	os/signal	2.739s
ok  	os/user	0.004s
ok  	path	0.004s
ok  	path/filepath	0.072s
ok  	reflect	0.102s
ok  	regexp	0.239s
ok  	regexp/syntax	0.707s
ok  	runtime	16.341s
?   	runtime/cgo	[no test files]
ok  	runtime/debug	0.007s
ok  	runtime/pprof	6.799s
?   	runtime/race	[no test files]
ok  	sort	0.088s
ok  	strconv	0.514s
ok  	strings	0.233s
ok  	sync	0.156s
ok  	sync/atomic	0.293s
ok  	syscall	0.013s
ok  	testing	1.230s
?   	testing/iotest	[no test files]
ok  	testing/quick	0.055s
ok  	text/scanner	0.006s
ok  	text/tabwriter	0.006s
ok  	text/template	0.045s
ok  	text/template/parse	0.015s
ok  	time	2.526s
ok  	unicode	0.004s
ok  	unicode/utf16	0.004s
ok  	unicode/utf8	0.008s
?   	unsafe	[no test files]

I've also tried latest release-branch.go1.4, got another error:

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
libbio
liblink
cmd/cc
cmd/gc
cmd/6l
cmd/6a
cmd/6c
/home/cholerae/test/go/src/cmd/6c/txt.c: In function 'gmove':
/home/cholerae/test/go/src/cmd/6c/txt.c:995:28: error: left shift of negative value [-Werror=shift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
/home/cholerae/test/go/src/cmd/6c/txt.c:1045:28: error: left shift of negative value [-Werror=shift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
cc1: all warnings being treated as errors
go tool dist: FAILED: gcc -Wall -Wstrict-prototypes -Wextra -Wunused -Wno-sign-compare -Wno-missing-braces -Wno-parentheses -Wno-unknown-pragmas -Wno-switch -Wno-comment -Wno-missing-field-initializers -Werror -fno-common -ggdb -pipe -Wuninitialized -O2 -fmessage-length=0 -c -m64 -I /home/cholerae/test/go/include -I /home/cholerae/test/go/src/cmlatest release-branch.go1.4d/6c -o $WORK/txt.o /home/cholerae/test/go/src/cmd/6c/txt.c
@choleraehyq

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2017

I use this patch on latest release-branch.go1.4 to work around gcc compile error:

diff --git a/src/cmd/dist/build.c b/src/cmd/dist/build.c
index d638ae4..34eff19 100644
--- a/src/cmd/dist/build.c
+++ b/src/cmd/dist/build.c
@@ -464,7 +464,6 @@ static char *proto_gccargs[] = {
        "-Wno-switch",
        "-Wno-comment",
        "-Wno-missing-field-initializers",
-       "-Werror",
        "-fno-common",
        "-ggdb",
        "-pipe",

Then I run CGO_ENABLED=0 ./all.bash (without CGO_ENABLED=0 I will get an unexpected relocation type error):

# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
libbio
liblink
cmd/cc
cmd/gc
cmd/6l
cmd/6a
cmd/6c
/home/cholerae/test/go/src/cmd/6c/txt.c: In function 'gmove':
/home/cholerae/test/go/src/cmd/6c/txt.c:995:28: warning: left shift of negative value [-Wshift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
/home/cholerae/test/go/src/cmd/6c/txt.c:1045:28: warning: left shift of negative value [-Wshift-negative-value]
     f->vconst |= (vlong)~0 << 32;
                            ^~
cmd/6g
runtime
errors
sync/atomic
sync
io
unicode
unicode/utf8
unicode/utf16
bytes
math
strings
strconv
bufio
sort
container/heap
encoding/base64
syscall
time
os
reflect
fmt
encoding
encoding/json
flag
path/filepath
path
io/ioutil
log
regexp/syntax
regexp
go/token
go/scanner
go/ast
go/parser
os/exec
os/signal
net/url
text/template/parse
text/template
go/doc
go/build
cmd/go

# Building packages and commands for linux/amd64.
runtime
errors
sync/atomic
unicode
sync
io
unicode/utf8
math
bytes
bufio
syscall
strconv
time
reflect
os
strings
fmt
encoding/binary
sort
regexp/syntax
cmd/internal/goobj
cmd/internal/rsc.io/arm/armasm
cmd/internal/rsc.io/x86/x86asm
debug/dwarf
debug/elf
debug/gosym
debug/macho
debug/pe
debug/plan9obj
regexp
text/tabwriter
flag
log
cmd/internal/objfile
hash
crypto
crypto/md5
go/token
path/filepath
cmd/addr2line
go/scanner
go/ast
io/ioutil
go/parser
go/printer
os/exec
path
container/heap
encoding
encoding/base64
cmd/cgo
go/format
cmd/fix
unicode/utf16
encoding/json
encoding/xml
net/url
text/template/parse
compress/flate
text/template
hash/crc32
compress/gzip
container/list
crypto/subtle
crypto/cipher
crypto/aes
go/doc
crypto/des
math/rand
go/build
math/big
crypto/hmac
internal/syscall
crypto/rc4
crypto/sha1
crypto/elliptic
encoding/asn1
crypto/rand
crypto/ecdsa
crypto/sha256
crypto/rsa
crypto/dsa
crypto/sha512
crypto/x509/pkix
encoding/hex
encoding/pem
net
mime
net/http/internal
os/signal
runtime/pprof
cmd/gofmt
cmd/nm
crypto/x509
crypto/tls
net/textproto
mime/multipart
cmd/objdump
net/http
cmd/pack
cmd/pprof/internal/profile
cmd/go
cmd/pprof/internal/plugin
html
html/template
cmd/pprof/internal/report
cmd/pprof/internal/svg
cmd/pprof/internal/tempfile
cmd/pprof/internal/commands
cmd/pprof/internal/driver
cmd/pprof/internal/fetch
cmd/pprof/internal/symbolizer
cmd/pprof/internal/symbolz
cmd/pprof
cmd/yacc
archive/tar
archive/zip
compress/bzip2
compress/lzw
hash/adler32
container/ring
compress/zlib
database/sql/driver
encoding/ascii85
database/sql
encoding/base32
encoding/csv
encoding/gob
expvar
hash/crc64
hash/fnv
image/color
image
image/color/palette
image/draw
image/jpeg
image/gif
image/png
index/suffixarray
log/syslog
math/cmplx
net/http/cgi
net/http/cookiejar
net/http/httptest
net/http/fcgi
net/http/httputil
net/http/pprof
net/mail
net/rpc
net/smtp
os/user
net/rpc/jsonrpc
runtime/debug
runtime/race
testing
testing/iotest
testing/quick
text/scanner

# Testing packages.
ok  	cmd/addr2line	0.674s
?   	cmd/cgo	[no test files]
ok  	cmd/fix	0.025s
ok  	cmd/go	0.012s
ok  	cmd/gofmt	0.110s
ok  	cmd/nm	0.678s
ok  	cmd/objdump	1.990s
ok  	cmd/pack	3.855s
?   	cmd/pprof	[no test files]
?   	cmd/yacc	[no test files]
ok  	archive/tar	0.023s
ok  	archive/zip	0.602s
ok  	bufio	0.177s
ok  	bytes	0.157s
ok  	cmd/internal/goobj	0.003s
?   	cmd/internal/objfile	[no test files]
?   	cmd/pprof/internal/commands	[no test files]
?   	cmd/pprof/internal/driver	[no test files]
?   	cmd/pprof/internal/fetch	[no test files]
?   	cmd/pprof/internal/plugin	[no test files]
?   	cmd/pprof/internal/profile	[no test files]
?   	cmd/pprof/internal/report	[no test files]
?   	cmd/pprof/internal/svg	[no test files]
?   	cmd/pprof/internal/symbolizer	[no test files]
?   	cmd/pprof/internal/symbolz	[no test files]
?   	cmd/pprof/internal/tempfile	[no test files]
ok  	compress/bzip2	0.094s
ok  	compress/flate	0.704s
ok  	compress/gzip	0.020s
ok  	compress/lzw	0.119s
ok  	compress/zlib	1.493s
ok  	container/heap	0.004s
ok  	container/list	0.003s
ok  	container/ring	0.019s
?   	crypto	[no test files]
ok  	crypto/aes	0.035s
ok  	crypto/cipher	0.012s
ok  	crypto/des	0.015s
ok  	crypto/dsa	0.012s
ok  	crypto/ecdsa	0.028s
ok  	crypto/elliptic	0.050s
ok  	crypto/hmac	0.004s
ok  	crypto/md5	0.007s
ok  	crypto/rand	0.017s
ok  	crypto/rc4	0.148s
ok  	crypto/rsa	0.233s
ok  	crypto/sha1	0.004s
ok  	crypto/sha256	0.005s
ok  	crypto/sha512	0.010s
ok  	crypto/subtle	0.007s
ok  	crypto/tls	1.831s
ok  	crypto/x509	1.560s
?   	crypto/x509/pkix	[no test files]
ok  	database/sql	0.062s
ok  	database/sql/driver	0.003s
ok  	debug/dwarf	0.024s
ok  	debug/elf	0.026s
ok  	debug/gosym	0.259s
ok  	debug/macho	0.016s
ok  	debug/pe	0.022s
ok  	debug/plan9obj	0.003s
?   	encoding	[no test files]
ok  	encoding/ascii85	0.004s
ok  	encoding/asn1	0.005s
ok  	encoding/base32	0.005s
ok  	encoding/base64	0.005s
ok  	encoding/binary	0.004s
ok  	encoding/csv	0.005s
ok  	encoding/gob	0.086s
ok  	encoding/hex	0.004s
ok  	encoding/json	0.217s
ok  	encoding/pem	0.005s
ok  	encoding/xml	0.019s
ok  	errors	0.003s
ok  	expvar	0.006s
ok  	flag	0.006s
ok  	fmt	0.053s
ok  	go/ast	0.009s
ok  	go/build	0.157s
ok  	go/doc	0.089s
ok  	go/format	0.011s
ok  	go/parser	0.051s
ok  	go/printer	0.427s
ok  	go/scanner	0.006s
ok  	go/token	0.043s
?   	hash	[no test files]
ok  	hash/adler32	0.016s
ok  	hash/crc32	0.005s
ok  	hash/crc64	0.003s
ok  	hash/fnv	0.003s
ok  	html	0.005s
ok  	html/template	0.055s
ok  	image	0.134s
ok  	image/color	0.010s
?   	image/color/palette	[no test files]
ok  	image/draw	0.105s
ok  	image/gif	0.083s
ok  	image/jpeg	0.269s
ok  	image/png	0.059s
ok  	index/suffixarray	0.013s
?   	internal/syscall	[no test files]
ok  	io	0.019s
ok  	io/ioutil	0.004s
ok  	log	0.008s
ok  	log/syslog	2.025s
ok  	math	0.005s
ok  	math/big	0.321s
ok  	math/cmplx	0.004s
ok  	math/rand	0.291s
ok  	mime	0.021s
ok  	mime/multipart	0.357s
--- FAIL: TestDialTimeout (0.02s)
	dial_test.go:100: all connections connected; expected some to time out
FAIL
FAIL	net	2.390s
ok  	net/http	4.755s
ok  	net/http/cgi	0.369s
ok  	net/http/cookiejar	0.011s
ok  	net/http/fcgi	0.007s
ok  	net/http/httptest	0.006s
ok  	net/http/httputil	0.018s
ok  	net/http/internal	0.005s
?   	net/http/pprof	[no test files]
ok  	net/mail	0.005s
ok  	net/rpc	0.029s
ok  	net/rpc/jsonrpc	0.017s
ok  	net/smtp	0.059s
ok  	net/textproto	0.005s
ok  	net/url	0.007s
ok  	os	0.624s
ok  	os/exec	0.263s
ok  	os/signal	2.747s
ok  	os/user	0.003s
ok  	path	0.004s
ok  	path/filepath	0.052s
ok  	reflect	0.096s
ok  	regexp	0.244s
ok  	regexp/syntax	0.775s
ok  	runtime	14.210s
ok  	runtime/debug	0.008s
ok  	runtime/pprof	6.851s
?   	runtime/race	[no test files]
ok  	sort	0.169s
ok  	strconv	0.580s
ok  	strings	0.158s
ok  	sync	0.124s
ok  	sync/atomic	0.319s
ok  	syscall	0.007s
ok  	testing	1.371s
?   	testing/iotest	[no test files]
ok  	testing/quick	0.044s
ok  	text/scanner	0.006s
ok  	text/tabwriter	0.006s
ok  	text/template	0.041s
ok  	text/template/parse	0.014s
--- FAIL: TestLoadFixed (0.01s)
	time_test.go:929: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL	time	2.504s
ok  	unicode	0.004s
ok  	unicode/utf16	0.003s
ok  	unicode/utf8	0.008s
?   	unsafe	[no test files]
@ALTree

This comment has been minimized.

Copy link
Member

commented Feb 6, 2017

go1.4 is no longer supported, so we don't fix failures in tests.

If you're building for bootstrapping, you should run make.bash and not all.bash.

@choleraehyq

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2017

If you're building for bootstrapping, you should run make.bash and not all.bash.

I think this should be written into documentation explicitly.

@ALTree

This comment has been minimized.

Copy link
Member

commented Feb 6, 2017

Done here: 1db1671, it'll be in the 1.8 docs.

Closing this, please open another issue if you encounter an error while running make.bash. This one is titled "TestDialTimeout flaky", which is not something that'll be fixed.

@ALTree ALTree closed this Feb 6, 2017

@bsed

This comment has been minimized.

Copy link

commented Jun 26, 2017

[root@localhost ~]# cd go/
[root@localhost go]# git checkout -b 1.4.3 go1.4.3
Switched to a new branch '1.4.3'
[root@localhost go]# cd src
[root@localhost src]# ./all.bash 
# Building C bootstrap tool.
cmd/dist

# Building compilers and Go bootstrap tool for host, linux/amd64.
lib9
libbio
liblink
cmd/cc
cmd/gc
cmd/6l
cmd/6a
cmd/6c
cmd/6g
runtime
errors
sync/atomic
sync
io
unicode
unicode/utf8
unicode/utf16
bytes
math
strings
strconv
bufio
sort
container/heap
encoding/base64
syscall
time
os
reflect
fmt
encoding
encoding/json
flag
path/filepath
path
io/ioutil
log
regexp/syntax
regexp
go/token
go/scanner
go/ast
go/parser
os/exec
os/signal
net/url
text/template/parse
text/template
go/doc
go/build
cmd/go

# Building packages and commands for linux/amd64.
runtime
errors
sync/atomic
unicode
unicode/utf8
math
sort
encoding
unicode/utf16
container/list
crypto/subtle
container/ring
image/color
runtime/race
sync
container/heap
image/color/palette
io
syscall
hash
crypto/cipher
hash/crc32
crypto/hmac
hash/adler32
hash/crc64
hash/fnv
bytes
strings
bufio
text/tabwriter
path
html
time
internal/syscall
compress/bzip2
strconv
math/rand
math/cmplx
reflect
regexp/syntax
crypto
encoding/base64
net/url
crypto/aes
crypto/rc4
encoding/ascii85
encoding/base32
image
os
crypto/md5
crypto/sha1
crypto/sha256
crypto/sha512
encoding/pem
image/draw
image/jpeg
path/filepath
os/signal
regexp
io/ioutil
os/exec
fmt
encoding/binary
cmd/pprof/internal/svg
crypto/des
index/suffixarray
cmd/internal/goobj
cmd/internal/rsc.io/arm/armasm
cmd/internal/rsc.io/x86/x86asm
debug/dwarf
debug/gosym
debug/plan9obj
flag
log
go/token
encoding/json
encoding/xml
text/template/parse
compress/flate
math/big
encoding/hex
mime
net/http/internal
runtime/pprof
cmd/pack
cmd/pprof/internal/tempfile
go/scanner
archive/tar
compress/lzw
database/sql/driver
encoding/csv
encoding/gob
image/gif
go/ast
runtime/debug
testing
database/sql
compress/gzip
debug/elf
debug/macho
debug/pe
cmd/pprof/internal/profile
archive/zip
text/template
compress/zlib
testing/iotest
testing/quick
text/scanner
crypto/elliptic
encoding/asn1
crypto/rand
crypto/dsa
image/png
crypto/rsa
cmd/internal/objfile
go/parser
go/printer
crypto/ecdsa
crypto/x509/pkix
go/doc
html/template
cmd/pprof/internal/plugin
cmd/pprof/internal/symbolz
cmd/pprof/internal/symbolizer
cmd/addr2line
cmd/nm
cmd/objdump
go/build
cmd/cgo
go/format
cmd/gofmt
cmd/fix
cmd/yacc
cmd/pprof/internal/report
cmd/pprof/internal/commands
cmd/pprof/internal/driver
runtime/cgo
net
os/user
crypto/x509
net/textproto
log/syslog
mime/multipart
net/mail
crypto/tls
net/http
net/smtp
cmd/go
cmd/pprof/internal/fetch
expvar
net/http/cgi
net/http/cookiejar
net/http/httptest
net/http/httputil
net/http/pprof
net/rpc
cmd/pprof
net/http/fcgi
net/rpc/jsonrpc

# Testing packages.
ok  	cmd/addr2line	0.896s
?   	cmd/cgo	[no test files]
ok  	cmd/fix	0.032s
ok  	cmd/go	0.023s
ok  	cmd/gofmt	0.065s
ok  	cmd/nm	0.984s
ok  	cmd/objdump	2.288s
ok  	cmd/pack	4.728s
?   	cmd/pprof	[no test files]
?   	cmd/yacc	[no test files]
ok  	archive/tar	0.020s
ok  	archive/zip	0.666s
ok  	bufio	0.296s
ok  	bytes	0.140s
ok  	cmd/internal/goobj	0.005s
?   	cmd/internal/objfile	[no test files]
?   	cmd/pprof/internal/commands	[no test files]
?   	cmd/pprof/internal/driver	[no test files]
?   	cmd/pprof/internal/fetch	[no test files]
?   	cmd/pprof/internal/plugin	[no test files]
?   	cmd/pprof/internal/profile	[no test files]
?   	cmd/pprof/internal/report	[no test files]
?   	cmd/pprof/internal/svg	[no test files]
?   	cmd/pprof/internal/symbolizer	[no test files]
?   	cmd/pprof/internal/symbolz	[no test files]
?   	cmd/pprof/internal/tempfile	[no test files]
ok  	compress/bzip2	0.111s
ok  	compress/flate	0.884s
ok  	compress/gzip	0.025s
ok  	compress/lzw	0.122s
ok  	compress/zlib	2.000s
ok  	container/heap	0.006s
ok  	container/list	0.012s
ok  	container/ring	0.046s
?   	crypto	[no test files]
ok  	crypto/aes	0.067s
ok  	crypto/cipher	0.015s
ok  	crypto/des	0.038s
ok  	crypto/dsa	0.021s
ok  	crypto/ecdsa	0.077s
ok  	crypto/elliptic	0.067s
ok  	crypto/hmac	0.005s
ok  	crypto/md5	0.022s
ok  	crypto/rand	0.065s
ok  	crypto/rc4	0.251s
ok  	crypto/rsa	0.299s
ok  	crypto/sha1	0.014s
ok  	crypto/sha256	0.027s
ok  	crypto/sha512	0.018s
ok  	crypto/subtle	0.010s
ok  	crypto/tls	2.101s
ok  	crypto/x509	1.900s
?   	crypto/x509/pkix	[no test files]
ok  	database/sql	0.120s
ok  	database/sql/driver	0.005s
ok  	debug/dwarf	0.030s
ok  	debug/elf	0.037s
ok  	debug/gosym	0.375s
ok  	debug/macho	0.006s
ok  	debug/pe	0.040s
ok  	debug/plan9obj	0.016s
?   	encoding	[no test files]
ok  	encoding/ascii85	0.017s
ok  	encoding/asn1	0.014s
ok  	encoding/base32	0.027s
ok  	encoding/base64	0.063s
ok  	encoding/binary	0.016s
ok  	encoding/csv	0.008s
ok  	encoding/gob	0.083s
ok  	encoding/hex	0.013s
ok  	encoding/json	0.242s
ok  	encoding/pem	0.007s
ok  	encoding/xml	0.042s
ok  	errors	0.005s
ok  	expvar	0.019s
ok  	flag	0.006s
ok  	fmt	0.077s
ok  	go/ast	0.011s
ok  	go/build	0.233s
ok  	go/doc	0.100s
ok  	go/format	0.045s
ok  	go/parser	0.037s
ok  	go/printer	0.535s
ok  	go/scanner	0.015s
ok  	go/token	0.080s
?   	hash	[no test files]
ok  	hash/adler32	0.015s
ok  	hash/crc32	0.004s
ok  	hash/crc64	0.033s
ok  	hash/fnv	0.016s
ok  	html	0.017s
ok  	html/template	0.063s
ok  	image	0.147s
ok  	image/color	0.026s
?   	image/color/palette	[no test files]
ok  	image/draw	0.146s
ok  	image/gif	0.105s
ok  	image/jpeg	0.326s
ok  	image/png	0.079s
ok  	index/suffixarray	0.044s
?   	internal/syscall	[no test files]
ok  	io	0.032s
ok  	io/ioutil	0.018s
ok  	log	0.019s
ok  	log/syslog	2.075s
ok  	math	0.007s
ok  	math/big	0.434s
ok  	math/cmplx	0.009s
ok  	math/rand	0.411s
ok  	mime	0.015s
ok  	mime/multipart	0.398s
ok  	net	2.547s
ok  	net/http	7.563s
ok  	net/http/cgi	0.448s
ok  	net/http/cookiejar	0.014s
ok  	net/http/fcgi	0.007s
ok  	net/http/httptest	0.012s
ok  	net/http/httputil	0.032s
ok  	net/http/internal	0.006s
?   	net/http/pprof	[no test files]
ok  	net/mail	0.008s
ok  	net/rpc	0.018s
ok  	net/rpc/jsonrpc	0.016s
ok  	net/smtp	0.079s
ok  	net/textproto	0.016s
ok  	net/url	0.011s
ok  	os	0.623s
ok  	os/exec	0.385s
ok  	os/signal	2.773s
ok  	os/user	0.006s
ok  	path	0.006s
ok  	path/filepath	0.035s
ok  	reflect	0.073s
ok  	regexp	0.248s
ok  	regexp/syntax	0.851s
ok  	runtime	11.125s
?   	runtime/cgo	[no test files]
ok  	runtime/debug	0.011s
ok  	runtime/pprof	6.510s
?   	runtime/race	[no test files]
ok  	sort	0.118s
ok  	strconv	0.493s
ok  	strings	0.129s
ok  	sync	0.137s
ok  	sync/atomic	0.293s
ok  	syscall	0.013s
ok  	testing	1.384s
?   	testing/iotest	[no test files]
ok  	testing/quick	0.054s
ok  	text/scanner	0.008s
ok  	text/tabwriter	0.008s
ok  	text/template	0.025s
ok  	text/template/parse	0.009s
--- FAIL: TestLoadFixed (0.01s)
	time_test.go:929: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL	time	2.461s
ok  	unicode	0.005s
ok  	unicode/utf16	0.004s
ok  	unicode/utf8	0.007s
?   	unsafe	[no test files]
@ALTree

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

@bsed Don't use all.bash for bootstrapping. You need to run make.bash. This is explicitly stated in the installing from sources doc page.

After unpacking the Go 1.4 source, cd to the src subdirectory and run make.bash (or, on Windows, make.bat).

@bsed

This comment has been minimized.

Copy link

commented Jul 3, 2017

en @ALTree

NexediGitlab pushed a commit to SlapOS/slapos that referenced this issue Nov 5, 2017

golang14: do not run tests on build
On some machines, net:TestDialTimeout never passes and today, Go 1.4 is only
used for bootstrapping, so let's not be more clever than Go devs, who
explicitly state to use make.bash

See also golang/go#18954

@golang golang locked and limited conversation to collaborators Jul 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.