Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: docs for CreateCertificate omit template.AuthorityKeyId yet it is used in code #18962

Closed
tylrtrmbl opened this issue Feb 6, 2017 · 3 comments
Assignees
Milestone

Comments

@tylrtrmbl
Copy link

@tylrtrmbl tylrtrmbl commented Feb 6, 2017

Documentation for crypto/x509.CreateCertficiate on the current golang.org page enumerates a list of fields from the certificate template that are considered when creating a certificate.

It omits the AuthorityKeyId field, but the source for buildExtensions, called by CreateCertificate, implies otherwise.

I would expect AuthorityKeyId to be added to the list of fields mentioned above in the documentation.

@odeke-em odeke-em changed the title Documentation for CreateCertificate forgets to include AuthorityKeyId crypto/x509: docs for CreateCertificate omit template.AuthorityKeyId yet it is used in code Feb 6, 2017
@odeke-em
Copy link
Member

@odeke-em odeke-em commented Feb 6, 2017

/cc @agl

@odeke-em odeke-em added this to the Go1.9 milestone Feb 6, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 8, 2017

CL https://golang.org/cl/36556 mentions this issue.

@gopherbot gopherbot closed this in bfe7c81 Feb 9, 2017
@tylrtrmbl
Copy link
Author

@tylrtrmbl tylrtrmbl commented Feb 9, 2017

Thank you @agl!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.