Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database/sql: lost connections (eventual hang) with context deadlines #18995

Closed
rsc opened this issue Feb 8, 2017 · 3 comments
Closed

database/sql: lost connections (eventual hang) with context deadlines #18995

rsc opened this issue Feb 8, 2017 · 3 comments
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Feb 8, 2017

See discussion on CL 36485.
@kardianos is working on a test.
I sent a draft fix.

@rsc rsc added this to the Go1.8 milestone Feb 8, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 8, 2017

CL https://golang.org/cl/36563 mentions this issue.

@rsc
Copy link
Contributor Author

@rsc rsc commented Feb 9, 2017

CL 36613 for cherry-pick to release branch.

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 9, 2017

CL https://golang.org/cl/36613 mentions this issue.

@gopherbot gopherbot closed this in 4f6d4bb Feb 9, 2017
@rsc rsc reopened this Feb 9, 2017
@rsc rsc closed this Feb 10, 2017
gopherbot pushed a commit that referenced this issue Feb 10, 2017
…n conn request timeout

Previously if a context was canceled while it was waiting for a
connection request, that connection request would leak.

To prevent this remove the pending connection request if the
context is canceled and ensure no connection has been sent on the channel.
This requires a change to how the connection requests are represented in the DB.

Fixes #18995

Change-Id: I9a274b48b8f4f7ca46cdee166faa38f56d030852
Reviewed-on: https://go-review.googlesource.com/36563
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/36613
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Feb 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.