Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gofmt: TestDiff failing on Plan 9 #18999

Closed
0intro opened this issue Feb 8, 2017 · 2 comments
Closed

cmd/gofmt: TestDiff failing on Plan 9 #18999

0intro opened this issue Feb 8, 2017 · 2 comments
Assignees
Milestone

Comments

@0intro
Copy link
Member

@0intro 0intro commented Feb 8, 2017

CL 36374 added TestDiff. This test is failing on Plan 9 because the equivalent of GNU diff on Plan 9 is ape/diff. On Plan 9, diff is a different program, which produces a different and incompatible output.

--- FAIL: TestDiff (0.04s)
	gofmt_test.go:199: got unexpected diff for difftest.txt
FAIL
FAIL	cmd/gofmt	0.127s

See https://build.golang.org/log/201f3a2ecb7cbff4a500863e3731b49a303a1271

@0intro 0intro added the OS-Plan9 label Feb 8, 2017
@0intro 0intro added this to the Go1.9Early milestone Feb 8, 2017
@0intro 0intro self-assigned this Feb 8, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 8, 2017

CL https://golang.org/cl/36650 mentions this issue.

@gopherbot gopherbot closed this in 12991a7 Feb 8, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 9, 2017

CL https://golang.org/cl/36644 mentions this issue.

gopherbot pushed a commit to golang/tools that referenced this issue Feb 9, 2017
Port of gofmt change at golang/go#18932 with golang/go#18999 fix

Change-Id: I8999d6a3e04946086dd159201dbc4b09338bf1c0
Reviewed-on: https://go-review.googlesource.com/36644
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Feb 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.