Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/mobile: document the requirements for running tests #19046
I'm trying to figure out why x/mobile tests are failing with my setup. Below is a list of failing tests, not sure what is the reason.
go version go1.7.4 darwin/amd64
What did you do?
What did you expect to see?
No failing tests.
What did you see instead?
Full output (7000 lines)
I'm not sure why the java_test.go:71 test is getting 2 classes instead of 1. Could you try
and see if that fixes that particular test? If not, could you paste the output from
Thanks, I've re-run the tests using https://go-review.googlesource.com/c/37320/ (184897121af27bc8e7d8edfd50f297e81db2f132).
The java test (java_test.go:71: got 2 classes, expected 1) finishes successfully.
Output of javap -J-Duser.language=en -s -protected -constants java.lang.Object and javap -J-Duser.language=en -s -protected -constants java.lang.Runnable
Full test output:
To avoid picking up a classpath from the CLASSPATH environment variable, always specify an explicit classpath to javap, even if is empty. Updates golang/go#19046. Change-Id: I2b3d941ba2779f90654117a046ae1600a53d5848 Reviewed-on: https://go-review.googlesource.com/37320 Reviewed-by: Hyang-Ah Hana Kim <firstname.lastname@example.org>
The test broke a long time ago when the underlying API changed. It seems too useful to remove outright, so disable it until someone cares enough to update it. Updates golang/go#19046. Change-Id: Iec49be30fbc2e3ffd6fa73e584b15a481751049f Reviewed-on: https://go-review.googlesource.com/37321 Reviewed-by: Hyang-Ah Hana Kim <email@example.com>
CL 30093 removed the go install step from gobind to avoid errors from circular dependencies with Java reverse wrapper. However, if a dependency is either never installed or outdated, gobind will fail. Reinstate the go install step, but ignore errors from the go install tool. Tested manually by wiping the $GOPATH/pkg directory and running the cmd/gobind tests. Updates golang/go#19046 Change-Id: I31832eccab09b2a7cf29e5d5bc1cc76963b7c2ef Reviewed-on: https://go-review.googlesource.com/37326 Reviewed-by: David Crawshaw <firstname.lastname@example.org>