Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: TestObjcSeqBench broken by 34643, simple fix #19048

Closed
8tt opened this issue Feb 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@8tt
Copy link

commented Feb 12, 2017

The TestObjcSeqBench test that is using SeqBench.m assumes that default name prefix is Go, but it was changed to empty in the following commit:

bind: make the default name prefix empty on ObjC
https://go-review.googlesource.com/#/c/34643/

go test golang.org/x/mobile/bind/objc -run TestObjcSeqBench

failed

Possible fix:
in SeqBench.m replace GoBench prefix with Bench, or allow passing prefix to test run

go version go1.7.4 darwin/amd64
gomobile version +60b0aaa Tue Jan 31 20:25:16 2017 +0000 (android,ios); androidSDK=

@gopherbot

This comment has been minimized.

Copy link

commented Feb 19, 2017

CL https://golang.org/cl/37199 mentions this issue.

@gopherbot

This comment has been minimized.

Copy link

commented Feb 21, 2017

CL https://golang.org/cl/37314 mentions this issue.

@golang golang locked and limited conversation to collaborators Feb 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.