Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
database/sql: investigate why TestIssue18719 requires closing rows before db close #19058
TestIssue18719 requires waiting for all the rows to close before closing the database. Otherwise the test will fail with:
I have no reason to believe this was introduced in go1.8. However it should be investigated and determined if this is a bug of some type of an intended behavior.
When a Tx starts a query, prevent returning the connection to the pool until after the query finishes. Fixes golang#19058 Change-Id: I2c0480d9cca9eeb173b5b3441a5aeed6f527e0ac Reviewed-on: https://go-review.googlesource.com/40400 Reviewed-by: Brad Fitzpatrick <email@example.com> Run-TryBot: Brad Fitzpatrick <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com>