Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: remove inl cost toolstash hacks #19081

Closed
josharian opened this issue Feb 14, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@josharian
Copy link
Contributor

commented Feb 14, 2017

CL 31674 was reverted because it caused a Google internal test to fail. It really should not have; it probably indicates an existing latent compiler bug. And I'd like to remove these hacks for 1.9. I don't have access to the test; this is a request to extract a public version of the test so I can try to fix it.

cc @mdempsky @dsnet

@josharian josharian added this to the Go1.9 milestone Feb 14, 2017

@mdempsky

This comment has been minimized.

Copy link
Member

commented Feb 14, 2017

FYI #18336.

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2017

Thanks! Closing as dup.

@josharian josharian closed this Feb 14, 2017

@golang golang locked and limited conversation to collaborators Feb 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.