Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: nil out and/or empty maps to assist GC #19095

Closed
josharian opened this issue Feb 14, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@josharian
Copy link
Contributor

commented Feb 14, 2017

CLs 37011 and 37012 suggest that the compiler is holding onto or building some large maps. Those CLs (or #19094) would help considerably. But we should also try to track down and nip the issue in the bud as well, if possible (which it might not be).

@josharian josharian added the ToolSpeed label Feb 14, 2017

@josharian josharian added this to the Go1.9 milestone Feb 14, 2017

@josharian josharian self-assigned this Feb 14, 2017

@josharian

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2017

Those CLs had bogus performance numbers. It would still be good to create some maps larger to begin with, but every attempt I've made at that in the past has been net negative. Closing this as not actionable for now.

@josharian josharian closed this Feb 17, 2017

@golang golang locked and limited conversation to collaborators Feb 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.