Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: newer FreeBSD builders #19097

Closed
bradfitz opened this issue Feb 15, 2017 · 8 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Feb 15, 2017

We don't have FreeBSD 11 builders (only 9 and 10).

Probably time to add them.

@paulzhol

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

I'd like to help, is it just updating https://github.com/golang/build/blob/master/env/freebsd-amd64/make.bash and creating a FreeBSD 11.0 image?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2017

Yes. I'd copy it to a new directory first so we don't delete the old one.

@paulzhol

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

I was thinking on just adding another 11.0) case to the switch. BTW should 10.1 be updated to 10.3?
Technically 9.3 is EOL since the start of 2017...

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2017

Oh, I missed that it has a switch. Great. Just continue that pattern.

You can update 10.1 to 10.3 but file a separate bug for me to deploy that first so we don't forget.

@gopherbot

This comment has been minimized.

Copy link

commented Feb 22, 2017

CL https://golang.org/cl/37389 mentions this issue.

@paulzhol

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

I've uploaded freebsd-amd64-gce103.tar.gz. While freebsd-amd64-gce110.tar.gz should be done in the morning.

Seeing this on the serial console:

2017/02/22 23:41:48 buildlet starting.
2017/02/22 23:41:48 Not remounting root filesystem due to missing buildlet-host-type metadata.
2017/02/22 23:41:48 Will listen on :80
2017/02/22 23:41:48 Adjusted MTU.
2017/02/22 23:41:48 Listening on :80 ...

what should buildlet-host-type be set to?

curl -v looks ok:

> GET / HTTP/1.1
> Host: 104.196.217.58
> User-Agent: curl/7.47.0
> Accept: */*
> 
< HTTP/1.1 200 OK
< Date: Wed, 22 Feb 2017 23:43:28 GMT
< Content-Length: 34
< Content-Type: text/plain; charset=utf-8
< 
buildlet running on freebsd-amd64
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2017

I will rebuild the images once the CL is submitted. If you got that far, it looks like they worked.

gopherbot pushed a commit to golang/build that referenced this issue Feb 23, 2017

env/freebsd-amd64: add FreeBSD 11.0 image, change 10.1 to 10.3
Verify checksum of downloaded image files.
Set cache=none on image disk.

Updates: golang/go#19097

Change-Id: Icae149fa9772f038b8946ee680f36e4e6f3db516
Reviewed-on: https://go-review.googlesource.com/37389
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@bradfitz bradfitz self-assigned this Feb 27, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2017

Okay, this is now deployed: https://go-review.googlesource.com/37498

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.