Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/loader: tests are too brittle #19152

Open
bradfitz opened this issue Feb 17, 2017 · 0 comments
Open

x/tools/go/loader: tests are too brittle #19152

bradfitz opened this issue Feb 17, 2017 · 0 comments
Labels
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Feb 17, 2017

The x/tools/go/loader tests have a history of breaking whenever something in the standard library
changes.

Or breaking when testing Go 1.6 vs Go 1.7 vs Go 1.8 vs Go tip, etc.

I think it's time to rethink those tests to not be a maintenance burden.

(Latest example: https://go-review.googlesource.com/c/37148/)

/cc @ianlancetaylor

@bradfitz bradfitz added the Testing label Feb 17, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Feb 17, 2017
gopherbot pushed a commit to golang/tools that referenced this issue Feb 17, 2017
Tip introduces a new internal/poll package that breaks the expected
output.

Fixes golang/go#19150
Updates golang/go#19152

Change-Id: I5ff7e8a92afe4d25feb6365933062e931c9b435f
Reviewed-on: https://go-review.googlesource.com/37148
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
@bradfitz bradfitz modified the milestones: Unreleased, Go1.9 Jun 14, 2017
@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.