Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/go/loader: tests are too brittle #19152
The x/tools/go/loader tests have a history of breaking whenever something in the standard library
Or breaking when testing Go 1.6 vs Go 1.7 vs Go 1.8 vs Go tip, etc.
I think it's time to rethink those tests to not be a maintenance burden.
(Latest example: https://go-review.googlesource.com/c/37148/)
Tip introduces a new internal/poll package that breaks the expected output. Fixes golang/go#19150 Updates golang/go#19152 Change-Id: I5ff7e8a92afe4d25feb6365933062e931c9b435f Reviewed-on: https://go-review.googlesource.com/37148 Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-by: Alan Donovan <email@example.com>