Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: String() on structs containing empty structs has changed #19246
Prior to 8958d8c (cmd/compile: skip convT2E for empty structs), the below test didn't call B.String(). After that commit it does, breaking a test that compared the result. I think this is actually a bug fix, but since that commit was supposed to be a pure performance improvement, some investigation is probably warranted.
In fact, the String method is called both on tip and on Go 1.8 (and before). On Go 1.8, it panics with nil pointer (
On Go 1.8, this code panics on