Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/parser: ParseFile using an *os.File as source seems slower than using a filename #19281

Closed
griesemer opened this issue Feb 24, 2017 · 1 comment
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Feb 24, 2017

Reminder to investigate. See also custom-code related to this in https://go-review.googlesource.com/#/c/37393 .

@griesemer griesemer self-assigned this Feb 24, 2017
@griesemer griesemer modified the milestones: Go1.9, Go1.9Maybe Feb 24, 2017
@griesemer griesemer modified the milestones: Go1.10, Go1.9Maybe Jun 16, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 23, 2017

Change https://golang.org/cl/85395 mentions this issue: go/parser: simplify code to read from an io.Reader (cleanup)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.