Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: add https support? #19315

Open
Happy-Ferret opened this issue Feb 28, 2017 · 5 comments

Comments

@Happy-Ferret
Copy link

commented Feb 28, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go1.8 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOOS="linux"

What did you do?

I'm trying to serve godoc on a server that enforces https redirection

godoc -http=:60000

What did you expect to see?

When I browsed to https://<url>:60000, I expected to see a working godoc landing page.

What did you see instead?

A page informing me of ERR_SSL_PROTOCOL_ERROR
"Unable to make a secure connection to the server"

Is there a way to serve godocs over https, using the godoc utility?

@bradfitz bradfitz changed the title godoc -http over https x/tools/godoc: add https support? Feb 28, 2017
@bradfitz

This comment has been minimized.

Copy link
Member

commented Feb 28, 2017

We do already have such support, but it's behind a build tag.

You can do:

$ go install --tags=autocert golang.org/x/tools/cmd/godoc

And then it'll listen on port 443 and use LetsEncrypt to get a cert.

We can use this bug to track making that more official.

@bradfitz bradfitz modified the milestones: Go1.8.1, Go1.9Maybe Feb 28, 2017
@Happy-Ferret

This comment has been minimized.

Copy link
Author

commented Mar 1, 2017

Thanks.

Any way to ``go get`´ this from Github? Golang.org is, for some reason, blocked at my company. Knowing the IT guys here, they'll have it unblocked just in time for Go 20.1...

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2017

I don't know whether go get works, but you can clone it from the https://github.com/golang/tools repo.

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 24, 2017

Pushing this to Go 1.10, by which time I hope we'll have our package management story more sorted out.

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 24, 2017

(as my change above depends on golang.org/x/crypto/autocert)

@bradfitz bradfitz modified the milestones: Go1.10, Unplanned Nov 15, 2017
@dmitshur dmitshur changed the title x/tools/godoc: add https support? x/tools/cmd/godoc: add https support? May 17, 2019
@gopherbot gopherbot added the Tools label Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.