Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: parameterize SizesFor? #19351

Closed
josharian opened this issue Mar 1, 2017 · 2 comments
Closed

go/types: parameterize SizesFor? #19351

josharian opened this issue Mar 1, 2017 · 2 comments
Milestone

Comments

@josharian
Copy link
Contributor

@josharian josharian commented Mar 1, 2017

CL 37583 added types.SizesFor. I'm delighted to see it.

If we add a GCSizes (#17586), will we need to also add a GCSizesFor? Do we want to parameterize SizesFor in some way to anticipate that change?

cc @griesemer @alandonovan

@josharian josharian added this to the Go1.9 milestone Mar 1, 2017
@griesemer
Copy link
Contributor

@griesemer griesemer commented Mar 1, 2017

I'm ok with adding a compiler parameter

func SizesFor(compiler string) Sizes

such that if the compiler is not recognized, it's some sensible default (perhaps what we have now). I would also be ok with just having SizesFor return the GC compiler's sizes (meaning underneath we'd do some extra work to match that).

But perhaps adding a compiler argument is the most future-proof and flexible approach. Comments?

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 2, 2017

CL https://golang.org/cl/37666 mentions this issue.

Loading

@gopherbot gopherbot closed this in 32a1736 Mar 2, 2017
@golang golang locked and limited conversation to collaborators Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants