Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: TestParseInLocation fail #19457

Closed
reusee opened this issue Mar 8, 2017 · 12 comments

Comments

Projects
None yet
6 participants
@reusee
Copy link

commented Mar 8, 2017

What did you do?

cd src/time
go test

What did you expect to see?

test pass

What did you see instead?

--- FAIL: TestParseInLocation (0.00s)
	format_test.go:264: ParseInLocation(Feb 01 2013 AST, Baghdad) = 2013-02-01 00:00:00 +0000 AST, want 2013-02-01 00:00:00 +0300 +03
FAIL
exit status 1
FAIL	time	8.438s

System details

go version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 linux/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/reus"
GORACE=""
GOROOT="/home/reus/go"
GOTOOLDIR="/home/reus/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build381570872=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +2bd6360e3b Wed Mar 8 03:24:44 2017 +0000 X:framepointer
uname -sr: Linux 4.9.11-1-ARCH
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.24, by Roland McGrath et al.
gdb --version: GNU gdb (GDB) 7.12.1
@ALTree

This comment has been minimized.

Copy link
Member

commented Mar 8, 2017

Here we go again.

The tzdata 2017a release changed the Baghdad abbreviation:

Changes to past and future time zone abbreviations
[..]
Similarly, switch from invented to numeric time zone
abbreviations for [..] Iraq [..]

We'll need to update the test, I'll send a patch.

@ALTree ALTree added this to the Go1.9 milestone Mar 8, 2017

@ALTree ALTree added Testing and removed Documentation labels Mar 8, 2017

@ianlancetaylor ianlancetaylor modified the milestones: Go1.8.1, Go1.9 Mar 8, 2017

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2017

Setting milestone to 1.8.1. If I understand this, this is going to have to ripple back through all the previous releases.

@gopherbot

This comment has been minimized.

Copy link

commented Mar 9, 2017

CL https://golang.org/cl/37964 mentions this issue.

@gopherbot gopherbot closed this in 91563ce Mar 9, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Mar 9, 2017

CL https://golang.org/cl/37991 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 9, 2017

[release-branch.go1.8] time: make the ParseInLocation test more robust
The tzdata 2017a update (2017-02-28) changed the abbreviation of the
Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the
numeric '+03'.

Update the test so that it skips the checks if we're using a recent
tzdata release.

Fixes #19457

Change-Id: I45d705a5520743a611bdd194dc8f8d618679980c
Reviewed-on: https://go-review.googlesource.com/37964
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 91563ce)
Reviewed-on: https://go-review.googlesource.com/37991
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Apr 4, 2017

CL https://golang.org/cl/39470 mentions this issue.

gopherbot pushed a commit to golang/gofrontend that referenced this issue Apr 4, 2017

time: make the ParseInLocation test more robust
This is a backport of https://golang.org/cl/37964 from the gc toolchain.

Original description:

    The tzdata 2017a update (2017-02-28) changed the abbreviation of the
    Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the
    numeric '+03'.

    Update the test so that it skips the checks if we're using a recent
    tzdata release.

Updates golang/go#19457
Fixes GCC PR 80302.

Change-Id: Id3fc522ae16569f9d6b416f44f1ff9639d460626
Reviewed-on: https://go-review.googlesource.com/39470
Reviewed-by: Than McIntosh <thanm@google.com>

pmatos pushed a commit to LinkiTools/gcc that referenced this issue Apr 4, 2017

ian
PR go/80302
    time: make the ParseInLocation test more robust
    
    This is a backport of https://golang.org/cl/37964 from the gc toolchain.
    
    Original description:
    
        The tzdata 2017a update (2017-02-28) changed the abbreviation of the
        Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the
        numeric '+03'.
    
        Update the test so that it skips the checks if we're using a recent
        tzdata release.
    
    Updates golang/go#19457
    Fixes GCC PR 80302.
    
    Reviewed-on: https://go-review.googlesource.com/39470


git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@246695 138bc75d-0d04-0410-961f-82ee72b054a4
@gopherbot

This comment has been minimized.

Copy link

commented Sep 25, 2017

Change https://golang.org/cl/66073 mentions this issue: [release-branch.go1.4] time: Skip TestParseInLocation test.

gopherbot pushed a commit that referenced this issue Oct 3, 2017

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue #19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue #17545.

Updates #20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

@ehrt74 ehrt74 referenced this issue Apr 3, 2018

Open

failing tests #37

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@marxenegls

This comment has been minimized.

Copy link

commented Jul 3, 2018

FAIL: TestParseInLocation compile go1.5 on armv7 using go1.4 bootstrap

What version of Go are you using (go version)?

1.4 bootstrap

Does this issue reproduce with the latest release?

1.5 src

What operating system and processor architecture are you using (go env)?

raspbian armv7l pi3 - 4.4.50-hypriotos-v7+

What did you do?

followed Dave Cheney's advice set ulimits added swap space even cleared page cache before compiling had a clear 600M ram and 1023 swap free

$ cd go/src
$ env GO_TEST_TIMEOUT_SCALE=10 GOROOT_BOOTSTRAP=$HOME/go-linux-arm-bootstrap ./all.bash

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

What did you expect to see?

success exit status 0 :)

What did you see instead?

ok text/template/parse 0.141s
--- FAIL: TestParseInLocation (0.02s) : p
format_test.go:202: ParseInLocation(Feb 01 2013 AST, Baghdad) = 2013-02-01 00:00:00 +0000 AST, want 2013-02-01 00:00:00 +0300 +03
--- FAIL: TestLoadFixed (0.01s)
time_test.go:943: Now().In(loc).Zone() = "-01", -3600, want "GMT+1", -3600
FAIL
FAIL time 5.582s
ok unicode 0.027s
ok unicode/utf16 0.021s
ok unicode/utf8 0.062s
ok cmd/addr2line 13.514s
ok cmd/api 0.065s
ok cmd/asm/internal/asm 0.274s
ok cmd/asm/internal/lex 0.027s
ok cmd/compile/internal/big 87.227s
ok cmd/cover 25.510s
ok cmd/doc 0.335s
ok cmd/fix 0.130s
ok cmd/go 301.585s
ok cmd/gofmt 1.007s
ok cmd/internal/goobj 0.018s
ok cmd/internal/obj 0.018s
ok cmd/internal/obj/x86 0.275s
ok cmd/internal/rsc.io/arm/armasm 0.069s
ok cmd/internal/rsc.io/x86/x86asm 3.826s
ok cmd/nm 14.115s
ok cmd/objdump 37.316s
ok cmd/pack 28.801s
ok cmd/pprof/internal/profile 0.067s
ok cmd/vet 51.834s
2018/07/03 01:30:39 Failed: exit status 1

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

@marxenegls This issue was closed long ago. Go 1.5 is no longer supported.

@marxenegls

This comment has been minimized.

Copy link

commented Jul 3, 2018

fixed i skipped the tests used ./make.bash
i wasn't aware , .. if i were i would'av avoided the issue the begin with.

@marxenegls

This comment has been minimized.

Copy link

commented Jul 3, 2018

@ianlancetaylor " This issue was closed long ago. Go 1.5 is no longer supported."
closed long ago ? there are two open remarks ..
well technically this issue is an old one not fixed .. from your reply i presumed i was using both an old tutt (https://dave.cheney.net/2015/09/04/building-go-1-5-on-the-raspberry-pi) and an older version of Go .. which was not exactly the case but i had to find that out for myself .. trying to build 1.10 on arm was a futile attempt ..so maybe you aren't aware of what runs on arm at this point in time ..
miscommunication ..
and i keep making the same mistake in presuming the latest version is somehow better

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2018

If the latest version (1.10.3) does not build on ARM, please file an issue about that. We don't support 1.5 but we do support 1.10 (and 1.9).

@davecheney

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2018

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018

[release-branch.go1.4] time: Skip TestParseInLocation test.
This test is now failing due to tz data updates (see issue golang#19457) - skip the test
since it does not impact the use of Go 1.4 for bootstrapping.

Similar to issue golang#17545.

Updates golang#20672

Change-Id: I8017159fa2a59b052c49fda7d50be7a863e0a08d
Reviewed-on: https://go-review.googlesource.com/66073
Reviewed-by: Ian Lance Taylor <iant@golang.org>

metux added a commit to oss-qm/go that referenced this issue Nov 8, 2018

time: make the ParseInLocation test more robust
The tzdata 2017a update (2017-02-28) changed the abbreviation of the
Asia/Baghdad time zone (used in TestParseInLocation) from 'AST' to the
numeric '+03'.

Update the test so that it skips the checks if we're using a recent
tzdata release.

Fixes golang#19457

Change-Id: I45d705a5520743a611bdd194dc8f8d618679980c
Reviewed-on: https://go-review.googlesource.com/37964
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.