Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: tests fail with LEAQ merging disabled #19475

Closed
mundaym opened this issue Mar 9, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@mundaym
Copy link
Member

commented Mar 9, 2017

This is possibly a red herring but I thought I'd post it anyway just in case it is a real bug. I've been experimenting with disabling address merging ((MOVQload (LEAQ ...) ...) -> (MOVQload ...) rules) and when I do I get a failure in the tests. Something similar happens on s390x.

What version of Go are you using (go version)?

https://go-review.googlesource.com/37990

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/munday/Development/gopath"
GORACE=""
GOROOT="/Users/munday/Development/go/master"
GOTOOLDIR="/Users/munday/Development/go/master/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/q0/9n8rk3pd4hx5cjxcq2rqctvm0000gn/T/go-build139713524=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

Run ./all.bash.

What did you expect to see?

Tests pass (well, maybe not... but not the error I get anyway).

What did you see instead?

# cmd/compile/internal/syntax
cmd/compile/internal/syntax/parser_test.go:33: invalid instruction: 00494 (/Users/munday/Development/go/master/src/cmd/compile/internal/syntax/parser_test.go:70)	MOVUPS	CX, DX
FAIL	cmd/compile/internal/syntax [build failed]

The MOVUPS appears to come from a moveByType call with a 16-byte string type.

@mundaym

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2017

@mundaym

This comment has been minimized.

Copy link
Member Author

commented Mar 9, 2017

Looks like this is a typo in the generic rules. I'll send a CL.

@gopherbot

This comment has been minimized.

Copy link

commented Mar 9, 2017

CL https://golang.org/cl/37869 mentions this issue.

@gopherbot gopherbot closed this in 945180f Mar 9, 2017

@golang golang locked and limited conversation to collaborators Mar 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.