net/http: ProxyFromEnvironment panics on malformed no_proxy contents #19536
Labels
Comments
CL https://golang.org/cl/38067 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In Go 1.8, the following example program:
panics on a
no_proxy
containing a malformed entry:The
:1
inno_proxy
should have been::1
, but a panic seems inappropriate in any case. Expected results would have been for the request to be proxied (as it did not match anyno_proxy
entries) or, possibly, return an error indicating that the proxy configuration couldn't be determined.go version go1.8 darwin/amd64, same problem also present in go1.7.4 so it's not a regression in 1.8.
The text was updated successfully, but these errors were encountered: