Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/ssadump: doesn't compile #19550

Closed
bradfitz opened this issue Mar 14, 2017 · 5 comments
Closed

x/tools/cmd/ssadump: doesn't compile #19550

bradfitz opened this issue Mar 14, 2017 · 5 comments
Labels
FrozenDueToAge NeedsFix
Milestone
Go1.9

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 14, 2017

The x/tools build is broken across the board:

https://build.golang.org/log/5caa4ff768a880d6f306a9546cb060eb5e592c29 etc:

# golang.org/x/tools/cmd/ssadump
2017/03/14 14:27:21 duplicate symbol golang.org/x/tools/go/ssa.(*BuilderMode).String (types 1 and 1) in main and $WORK/golang.org/x/tools/go/ssa.a(_go_.o)
@bradfitz bradfitz added the NeedsFix label Mar 14, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Mar 14, 2017
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 14, 2017

I think that this was broken by https://golang.org/cl/38139 and I think that the fix is in https://golang.org/cl/38156.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Mar 14, 2017

CC @dr2chase @philhofer

@griesemer griesemer removed their assignment Mar 14, 2017
@philhofer
Copy link
Contributor

@philhofer philhofer commented Mar 14, 2017

Confirmed dupe of #19548.

@josharian
Copy link
Contributor

@josharian josharian commented Mar 14, 2017

Closing as dup.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2017

CL https://golang.org/cl/38156 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 15, 2017
@philhofer @dr2chase
cmd/compile/internal/gc: mark generated wrappers as DUPOK
710f4d3 
Interface wrapper functions now get compiled eagerly in some cases.
Consequently, they may be present in multiple translation units.
Mark them as DUPOK, just like closures.

Fixes #19548
Fixes #19550

Change-Id: Ibe74adb5a62dbf6447db37fde22dcbb3479969ef
Reviewed-on: https://go-review.googlesource.com/38156
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators Mar 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix
Projects
None yet
Milestone
Go1.9
Development

No branches or pull requests
7 participants
@bradfitz @josharian @philhofer @ianlancetaylor @alandonovan @griesemer @gopherbot