Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/perf/benchstat: geomean includes benchmarks that are in only one file #19565
The geomean should be 0.
I'm not positive what the "right" behavior here is, though the current behavior is clearly not it. :)
Should we show benchmarks that don't match or not? It's kind of annoying that we silently drop that information, and it makes benchstat somewhat less predictable. That suggests we should show such benchmarks in the appropriate column. But that makes the geomeans definitely less useful, and makes the geomean delta completely meaningless.
Perhaps we should show non-matching benchmarks in their own group after the geomean row, probably separated by a blank line?