x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit

[bradfitz]

Have gopherbot ping a CL when it has +2 but OP can't submit.

[bradfitz]

Temporary workaround: (search only works for people with sufficient Gerritt access)

https://go-review.googlesource.com/#/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%22approvers%22+AND+-ownerin:%22admins%22)

Gopherbot work is underway in http://golang.org/cl/38385

/cc @aclements @kevinburke

[bradfitz]

GitHub seems to munge that URL. Let's try this:

https://go-review.googlesource.com/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%2522approvers%2522+AND+-ownerin:%2522admins%2522)

[bradfitz]

@andybons, I was just discussing this bug with @robpike. Even if we fix this, it doesn't help Upspin or Perkeep, etc. This seems like something that Gerrit should just surface in the UI, to highlight when something is +2'ed (or otherwise submittable) but the Author doesn't have permission themselves to press Submit.

Could you file a Gerrit bug using the correct Gerrit terminology?

[andybons]

https://bugs.chromium.org/p/gerrit/issues/detail?id=9247

[bradfitz]

Gerrit changed and we can no longer do that query.

More motivation to fix this bug and do it ourselves.

/cc @dmitshur @bcmills

[bradfitz]

I submited ACL change https://go-review.googlesource.com/c/All-Projects/+/178682 to let gopherbot have access to this info.

[bradfitz]

... well, that didn't work. The only way I can get gopherbot to have access to query a group's members is to make gobot be an admin, which I'd rather not do.

@andybons, do you know which permissions/capabilities our gobot user needs to have in order to use https://godoc.org/golang.org/x/build/gerrit#Client.GetGroupMembers ?

[gopherbot]

Change https://golang.org/cl/178702 mentions this issue: cmd/gopherbot: add manual mode to dump who needs access