Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit #19572

Open
bradfitz opened this Issue Mar 16, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

bradfitz commented Mar 16, 2017

Have gopherbot ping a CL when it has +2 but OP can't submit.

@bradfitz bradfitz added this to the Unreleased milestone Mar 16, 2017

@bradfitz bradfitz self-assigned this Mar 16, 2017

@gopherbot gopherbot added the Builders label Mar 21, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Mar 21, 2017

Temporary workaround: (search only works for people with sufficient Gerritt access)

https://go-review.googlesource.com/#/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%22approvers%22+AND+-ownerin:%22admins%22)

Gopherbot work is underway in http://golang.org/cl/38385

/cc @aclements @kevinburke

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Mar 21, 2017

GitHub seems to munge that URL. Let's try this:

https://go-review.googlesource.com/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%2522approvers%2522+AND+-ownerin:%2522admins%2522)

@bradfitz bradfitz changed the title x/build: have gopherbot ping a CL when it has +2 but OP can't submit x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit Mar 21, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Jun 11, 2018

@andybons, I was just discussing this bug with @robpike. Even if we fix this, it doesn't help Upspin or Perkeep, etc. This seems like something that Gerrit should just surface in the UI, to highlight when something is +2'ed (or otherwise submittable) but the Author doesn't have permission themselves to press Submit.

Could you file a Gerrit bug using the correct Gerrit terminology?

@andybons

This comment has been minimized.

@bradfitz

This comment has been minimized.

Copy link
Member Author

bradfitz commented Aug 24, 2018

Gerrit changed and we can no longer do that query.

More motivation to fix this bug and do it ourselves.

/cc @dmitshur @bcmills

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.