Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit #19572

Open
bradfitz opened this issue Mar 16, 2017 · 8 comments

Comments

@bradfitz
Copy link
Member

commented Mar 16, 2017

Have gopherbot ping a CL when it has +2 but OP can't submit.

@bradfitz bradfitz added this to the Unreleased milestone Mar 16, 2017

@bradfitz bradfitz self-assigned this Mar 16, 2017

@gopherbot gopherbot added the Builders label Mar 21, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2017

Temporary workaround: (search only works for people with sufficient Gerritt access)

https://go-review.googlesource.com/#/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%22approvers%22+AND+-ownerin:%22admins%22)

Gopherbot work is underway in http://golang.org/cl/38385

/cc @aclements @kevinburke

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2017

GitHub seems to munge that URL. Let's try this:

https://go-review.googlesource.com/q/status:open+label:Code-Review%253D%252B2+(-ownerin:%2522approvers%2522+AND+-ownerin:%2522admins%2522)

@bradfitz bradfitz changed the title x/build: have gopherbot ping a CL when it has +2 but OP can't submit x/build/cmd/gopherbot: ping a CL when it has +2 but OP can't submit Mar 21, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2018

@andybons, I was just discussing this bug with @robpike. Even if we fix this, it doesn't help Upspin or Perkeep, etc. This seems like something that Gerrit should just surface in the UI, to highlight when something is +2'ed (or otherwise submittable) but the Author doesn't have permission themselves to press Submit.

Could you file a Gerrit bug using the correct Gerrit terminology?

@andybons

This comment has been minimized.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2018

Gerrit changed and we can no longer do that query.

More motivation to fix this bug and do it ourselves.

/cc @dmitshur @bcmills

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

I submited ACL change https://go-review.googlesource.com/c/All-Projects/+/178682 to let gopherbot have access to this info.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

... well, that didn't work. The only way I can get gopherbot to have access to query a group's members is to make gobot be an admin, which I'd rather not do.

@andybons, do you know which permissions/capabilities our gobot user needs to have in order to use https://godoc.org/golang.org/x/build/gerrit#Client.GetGroupMembers ?

@gopherbot

This comment has been minimized.

Copy link

commented May 23, 2019

Change https://golang.org/cl/178702 mentions this issue: cmd/gopherbot: add manual mode to dump who needs access

gopherbot pushed a commit to golang/build that referenced this issue May 30, 2019
cmd/gopherbot: add manual mode to dump who needs access
Updates golang/go#19572

Change-Id: Ied3fc5f9e4c72eec5a65151f4d44f57119109367
Reviewed-on: https://go-review.googlesource.com/c/build/+/178702
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.