Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) #19578
Labels
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
(Original bug is #19425) Sounds fine to me. @ianlancetaylor? |
This comment has been minimized.
This comment has been minimized.
|
SGTM |
This comment has been minimized.
This comment has been minimized.
|
Sorry not sure of the process here, should I create a CL against go 1.8? |
This comment has been minimized.
This comment has been minimized.
|
@laboger Sure, that would help. Thanks. |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/38472 mentions this issue. |
gopherbot
pushed a commit
that referenced
this issue
Mar 23, 2017
Previously call stubs were generated and inserted in Textp after much of the text, resulting in calls too far in some cases. This puts the call stubs first, which in many cases makes some calls not so far, but also enables trampolines to be generated when necessary. This is a backport for go 1.8 based on CL38131. Fixes #19578 Change-Id: If3ba3d5222a7f7969ed2de1df4854a1b4a80a0f0 Reviewed-on: https://go-review.googlesource.com/38472 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This comment has been minimized.
This comment has been minimized.
|
Closing since committed to release branch. |
bradfitz
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version)?go 1.8
What operating system and processor architecture are you using (
go env)?RH 7 ppc64le
I'd like to request a backport of https://go-review.googlesource.com/c/38131/ to go1.8. This patch is needed to fix a problem in the Kubernetes build when using go 1.8.