Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) #19578

Closed
laboger opened this issue Mar 16, 2017 · 6 comments

Comments

Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix
Projects
None yet
Milestone
  Go1.8.1
5 participants
@laboger @bradfitz @ianlancetaylor @gopherbot @aclements
@laboger
Copy link
Contributor

commented Mar 16, 2017

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go 1.8

What operating system and processor architecture are you using (go env)?

RH 7 ppc64le

I'd like to request a backport of https://go-review.googlesource.com/c/38131/ to go1.8. This patch is needed to fix a problem in the Kubernetes build when using go 1.8.
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Member

commented Mar 16, 2017 •
edited

(Original bug is #19425)

Sounds fine to me. @ianlancetaylor?

@bradfitz bradfitz added this to the Go1.8.1 milestone Mar 16, 2017

@bradfitz bradfitz added the NeedsDecision label Mar 16, 2017

@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 16, 2017

SGTM

@bradfitz bradfitz added NeedsFix and removed NeedsDecision labels Mar 16, 2017

@cherrymui cherrymui referenced this issue Mar 19, 2017

Closed

cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes #19425

@laboger

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

commented Mar 22, 2017

Sorry not sure of the process here, should I create a CL against go 1.8?
@ianlancetaylor

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 22, 2017

@laboger Sure, that would help. Thanks.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

commented Mar 23, 2017

CL https://golang.org/cl/38472 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 23, 2017

@laboger @bradfitz
[release-branch.go1.8] cmd/link: put plt stubs first in Textp on ppc64x 
Previously call stubs were generated and inserted in
Textp after much of the text, resulting in calls too
far in some cases. This puts the call stubs first, which
in many cases makes some calls not so far, but also
enables trampolines to be generated when necessary.

This is a backport for go 1.8 based on CL38131.

Fixes #19578

Change-Id: If3ba3d5222a7f7969ed2de1df4854a1b4a80a0f0
Reviewed-on: https://go-review.googlesource.com/38472
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
d431307
@aclements

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 5, 2017

Closing since committed to release branch.

@aclements aclements closed this Apr 5, 2017

@bradfitz bradfitz changed the title cmd/link: request backport of CL 38131 to go 1.8 cmd/link: ppc64x direct call too far: net(.text).malloc while building kubernetes (backport) Apr 7, 2017

@golang golang locked and limited conversation to collaborators Apr 7, 2018

@gopherbot gopherbot added the FrozenDueToAge label Apr 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.