New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: false negative in vet -shadow #19597

Open
mcandre opened this Issue Mar 17, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@mcandre

mcandre commented Mar 17, 2017

What version of Go are you using (go version)?

$ go version
go version go1.7 darwin/amd64

What did you do?

go tool vet -shadow finds one shadow for the hash variable, but fails to notice the password shadow.

Source:

https://github.com/mcandre/go-ios7crypt/blob/61a282b2d8003e9372cbe37449c7008ee142f1fa/cmd/ios7crypt/main.go#L29-L43

Perhaps the shadow checker bombs out on the first occurrence, before it has a chance to scan the rest of the file?

@ALTree ALTree changed the title from False negative in vet -shadow to cmd/vet: false negative in vet -shadow Mar 18, 2017

@ALTree ALTree added this to the Unplanned milestone Mar 18, 2017

@robpike

This comment has been minimized.

Contributor

robpike commented Mar 18, 2017

The shadow tool is very weak and has many known bugs. I'll leave this open but don't expect a fix. A likelier resolution is a complete replacement of the checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment