cmd/vet: false negative in vet -shadow

[mcandre]

What version of Go are you using (go version)?

$ go version
go version go1.7 darwin/amd64

What did you do?

go tool vet -shadow finds one shadow for the hash variable, but fails to notice the password shadow.

Source:

https://github.com/mcandre/go-ios7crypt/blob/61a282b2d8003e9372cbe37449c7008ee142f1fa/cmd/ios7crypt/main.go#L29-L43

Perhaps the shadow checker bombs out on the first occurrence, before it has a chance to scan the rest of the file?

[robpike]

The shadow tool is very weak and has many known bugs. I'll leave this open but don't expect a fix. A likelier resolution is a complete replacement of the checker.