cmd/vet: false negative in vet -shadow #19597
Closed
Labels
Milestone
Comments
The shadow tool is very weak and has many known bugs. I'll leave this open but don't expect a fix. A likelier resolution is a complete replacement of the checker. |
Given that the check never made it out of the "experimental" phase, and that it's no longer part of vet, and that noone plans to fix this issue in particular, I'm closing it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version
)?What did you do?
go tool vet -shadow
finds one shadow for thehash
variable, but fails to notice thepassword
shadow.Source:
https://github.com/mcandre/go-ios7crypt/blob/61a282b2d8003e9372cbe37449c7008ee142f1fa/cmd/ios7crypt/main.go#L29-L43
Perhaps the shadow checker bombs out on the first occurrence, before it has a chance to scan the rest of the file?
The text was updated successfully, but these errors were encountered: