Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: export specialized variants of runtime._type to debug_info #19602

Closed
aarzilli opened this issue Mar 18, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@aarzilli
Copy link
Contributor

commented Mar 18, 2017

The reflect package can be used to create new types at runtime, these types will have runtime._type entries describing them but no entry in debug_info (obviously).

A debugger that wanted to print the value of variables with such types will have to read the runtime._type directly, however the "specializations" of runtime._type (runtime.slicetype, runtime.maptype, etc) are not exported to debug_info, besides runtime.interfacetype.

All those types (i.e. runtime.slicetype, runtime.maptype, etc) should be exported to debug_info so that debuggers don't have to hard-code their description.

@gopherbot

This comment has been minimized.

Copy link

commented Mar 18, 2017

CL https://golang.org/cl/38350 mentions this issue.

@bradfitz bradfitz added this to the Go1.9 milestone Mar 21, 2017

@gopherbot gopherbot closed this in 073247f Apr 12, 2017

lparth added a commit to lparth/go that referenced this issue Apr 13, 2017

cmd/link: export specialized variants of runtime._type to debug_info
The reflect package can be used to create new types at runtime, these
types will have runtime._type entries describing them but no entry in
debug_info (obviously).

A debugger that wanted to print the value of variables with such types
will have to read the runtime._type directly, however the
"specializations" of runtime._type (runtime.slicetype, runtime.maptype,
etc) are not exported to debug_info, besides runtime.interfacetype.

All those types (i.e. runtime.slicetype, runtime.maptype, etc) should
be exported to debug_info so that debuggers don't have to hard-code
their description.

Fixes golang#19602

Change-Id: I086d523a4421a4ed964e16bc3c2274319a98b45b
Reviewed-on: https://go-review.googlesource.com/38350
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>

@golang golang locked and limited conversation to collaborators Apr 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.