Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Transport crash in tryPutIdleConn #19605

Closed
bradfitz opened this issue Mar 18, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@bradfitz
Copy link
Member

commented Mar 18, 2017

Test flake in trybot run of https://go-review.googlesource.com/c/38351/

https://storage.googleapis.com/go-build-log/7db6e167/linux-amd64-race_2fc40adc.log

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x428943]

goroutine 136 [running]:
net/http.(*Transport).tryPutIdleConn(0xc42032c5a0, 0xc42033fb00, 0x0, 0x0)
	/tmp/workdir/go/src/net/http/transport.go:688 +0x29a
net/http.(*persistConn).readLoop.func2(0x0, 0xc420386201)
	/tmp/workdir/go/src/net/http/transport.go:1490 +0x6f
net/http.(*persistConn).readLoop(0xc42033fb00)
	/tmp/workdir/go/src/net/http/transport.go:1587 +0x1549
created by net/http.(*Transport).dialConn
	/tmp/workdir/go/src/net/http/transport.go:1168 +0xbf5
FAIL	net/http	0.207s

@bradfitz bradfitz added this to the Go1.9 milestone Mar 18, 2017

@bradfitz bradfitz self-assigned this Mar 18, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2017

Maybe CL 38351 is to blame? But in case it's not, filing this.

@mvdan

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

Likely caused by the CL - the runtime channel code it touches has raceenabled in there, so it could be that I simply broke -race. I'll look into this tomorrow.

@bradfitz bradfitz assigned mvdan and unassigned bradfitz Mar 18, 2017

@mvdan

This comment has been minimized.

Copy link
Member

commented Mar 18, 2017

Yeah, I can reproduce the crash via go test -race net/http. Closing as it's a regression in the CL, not a flake already present in tip.

@mvdan mvdan closed this Mar 18, 2017

@golang golang locked and limited conversation to collaborators Mar 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.