Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: make trybots refuse to test a commit that's too old #19664

Open
bradfitz opened this issue Mar 22, 2017 · 10 comments

Comments

Projects
None yet
4 participants
@bradfitz
Copy link
Member

commented Mar 22, 2017

Make trybots refuse to test a commit with a git parent over N commits or days old.

Related to but different than #9858

@gopherbot gopherbot added this to the Unreleased milestone Mar 22, 2017

@gopherbot gopherbot added the Builders label Mar 22, 2017

@mxplusb

This comment has been minimized.

Copy link

commented Apr 4, 2017

Where is the logic for the trybots?

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2017

golang.org/x/build/cmd/coordinator in coordinator.go

@quentinmit

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2017

Beware of how you apply this logic to subrepos, because the latest commit can easily be N days old.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 4, 2017

CL https://golang.org/cl/39536 mentions this issue.

@mxplusb

This comment has been minimized.

Copy link

commented Apr 4, 2017

I set it to 43800 minutes for a tryset's parent/parents, which is 30 days.

@mxplusb

This comment has been minimized.

Copy link

commented Dec 7, 2017

Is this still relevant? I saw my name at the top of https://dev.golang.org/reviews with it attached to this, so I wanted to see if it still needs attention from me. The last comments on the review were mine.

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2017

This would still be nice to have done, but it should be based on number of git commits back rather than time.

Also, the CL above has merge conflicts and needs to be rebased.

@mxplusb

This comment has been minimized.

Copy link

commented Dec 7, 2017

@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2017

I'm not sure. Too few and it's annoying.

It might need to be some combination of N commits back and time back, and maybe whether the build was broken & fixed in the meantime, but that's kinda tricky.

We could start with just something like it's okay to run trybots it's fewer than 10 commits old OR less than 5 days. But once it's older than 10 commits AND older than 5 days, then we make them rebase? We can adjust the thresholds later.

@gopherbot

This comment has been minimized.

Copy link

commented Apr 2, 2019

Change https://golang.org/cl/170457 mentions this issue: cmd/coordinator: on trybot failure, mention that trybots don't rebase

gopherbot pushed a commit to golang/build that referenced this issue Apr 2, 2019

cmd/coordinator: on trybot failure, mention that trybots don't rebase
Updates golang/go#19664
Updates golang/go#9858
Updates golang/go#30807

Change-Id: I378979e2745b4d34286a3a038161eb03148771e7
Reviewed-on: https://go-review.googlesource.com/c/build/+/170457
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.