Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: Hijack deadlock if system clock is 1970 (backport) #19771

Closed
bradfitz opened this issue Mar 29, 2017 · 0 comments
Closed

net/http: Hijack deadlock if system clock is 1970 (backport) #19771

bradfitz opened this issue Mar 29, 2017 · 0 comments
Assignees
@bradfitz
Labels
FrozenDueToAge
Milestone
Go1.8.1

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Mar 29, 2017 •
edited

Backport #19747 (https://golang.org/cl/38785) to Go 1.8.1
@bradfitz bradfitz added this to the Go1.8.1 milestone Mar 29, 2017
@bradfitz bradfitz self-assigned this Mar 29, 2017
gopherbot pushed a commit that referenced this issue Mar 29, 2017
@bradfitz
[release-branch.go1.8] net, net/http: adjust time-in-past constant ev…
Loading status checks…
e35c01b 
…en earlier

The aLongTimeAgo time value in net and net/http is used to cancel
in-flight read and writes. It was set to time.Unix(233431200, 0)
which seemed like far enough in the past.

But Raspberry Pis, lacking a real time clock, had to spoil the fun and
boot in 1970 at the Unix epoch time, breaking assumptions in net and
net/http.

So change aLongTimeAgo to time.Unix(1, 0), which seems like the
earliest safe value. I don't trust subsecond values on all operating
systems, and I don't trust the Unix zero time. The Raspberry Pis do
advance their clock at least. And the reported problem was that Hijack
on a ResponseWriter hung forever, waiting for the connection read
operation to finish. So now, even if kernel + userspace boots in under
a second (unlikely), the Hijack will just have to wait for up to a
second.

Updates #19747
Fixes #19771 (backport to Go 1.8.x)

Change-Id: Id59430de2e7b5b5117d4903a788863e9d344e53a
Reviewed-on: https://go-review.googlesource.com/38785
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
(cherry picked from commit e83fc2e44336423dab94bfe74fad4c4e6a4703b3)
Reviewed-on: https://go-review.googlesource.com/38786
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz bradfitz closed this Mar 29, 2017
@golang golang locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bradfitz bradfitz

Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.8.1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bradfitz @gopherbot