Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: TestDWARF failing on non-cgo platforms #19793

Closed
0intro opened this issue Mar 30, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@0intro
Copy link
Member

commented Mar 30, 2017

TestDWARF has been added in CL 38855 and is failing on Plan 9. This is happening because Plan 9 executable don't have a DWARF symbol table.

--- FAIL: TestDWARF (3.40s)
    --- FAIL: TestDWARF/testprog (1.40s)
    	dwarf_test.go:71: no DWARF data in Plan 9 file
    --- FAIL: TestDWARF/testprogcgo (0.79s)
    	dwarf_test.go:44: go build -o /tmp/go-link-TestDWARF336257136/testprogcgo.exe ../../runtime/testdata/testprogcgo: exit status: 'go 5236: 2'
    		# _/tmp/workdir/go/src/runtime/testdata/testprogcgo
    		../../runtime/testdata/testprogcgo/dropm_stub.go:11:6: missing function body for "runtime_getm_for_test"
FAIL
FAIL	cmd/link	3.436s

See https://build.golang.org/log/f37d663d3b605d05dfbd599a3ceedc1fd8f135a6

@0intro 0intro added the OS-Plan9 label Mar 30, 2017

@0intro 0intro added this to the Go1.9Early milestone Mar 30, 2017

@0intro 0intro self-assigned this Mar 30, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Mar 30, 2017

CL https://golang.org/cl/38931 mentions this issue.

@gopherbot gopherbot closed this in ed6f297 Mar 30, 2017

@cherrymui

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2017

The test also fails on other no-cgo platforms:
linux-amd64-nocgo builder: https://build.golang.org/log/8380330b9d0d32bc1493a677f7fc6126c0398507
big-endian PPC64 builder: https://build.golang.org/log/e1c9310c4f3712b78e63d60e5510ea1ac4658672

@bradfitz bradfitz reopened this Mar 30, 2017

@bradfitz bradfitz added the NeedsFix label Mar 30, 2017

@bradfitz bradfitz changed the title cmd/link: TestDWARF failing on Plan 9 cmd/link: TestDWARF failing on non-cgo platforms Mar 30, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

Non-cgo tracked in #19796

@bradfitz bradfitz closed this Mar 30, 2017

@gopherbot

This comment has been minimized.

Copy link

commented Apr 5, 2017

CL https://golang.org/cl/39611 mentions this issue.

gopherbot pushed a commit that referenced this issue Apr 5, 2017

[release-branch.go1.8] cmd/link: skip TestDWARF on Plan 9
TestDWARF has been added in CL 38855. This test is
failing on Plan 9 because executables don't have
a DWARF symbol table.

Fixes #19793.

(This fixes Plan 9 failures on the release branch introduced by
cherry-pick CL 39605.)

Change-Id: I7fc547a7c877b58cc4ff6b4eb5b14852e8b4668b
Reviewed-on: https://go-review.googlesource.com/39611
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>

lparth added a commit to lparth/go that referenced this issue Apr 13, 2017

cmd/link: skip TestDWARF on Plan 9
TestDWARF has been added in CL 38855. This test is
failing on Plan 9 because executables don't have
a DWARF symbol table.

Fixes golang#19793.

Change-Id: I7fc547a7c877b58cc4ff6b4eb5b14852e8b4668b
Reviewed-on: https://go-review.googlesource.com/38931
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>

@golang golang locked and limited conversation to collaborators Apr 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.