net: Windows test use PowerShell "getmac", not always available

[bradfitz]

The Windows tests use PowerShell "getmac", which only works in Windows Server 2008.

In 2012 and 2016, it fails.

Maybe the replacement is now "Get-NetAdapter | select Name,MacAddress" ?

/cc @alexbrainman @mikioh

[gopherbot]

CL https://golang.org/cl/41395 mentions this issue.

[as]

Wouldn't wmic nic get Name,MACAddress be easier? Almost every version of Windows since XP supports it.

[bradfitz]

@as, feel free to fix things up. I don't know Windows well so I just disabled the test.

[siennathesane]

@bradfitz what is getmac used for in the larger scope?

[alexbrainman]

@bradfitz what is getmac used for in the larger scope?

Perhaps I do not understand your question. But getmac command is used in TestInterfaceHardwareAddrWithGetmac in net package.

Alex

[siennathesane]

Sorry, I meant what is the reason for shelling out getmac instead of just making the syscall? Is there a specific reason for doing so?

[alexbrainman]

I meant what is the reason for shelling out getmac instead of just making the syscall?

TestInterfaceHardwareAddrWithGetmac tests the syscall. How do you propose to test syscall by calling syscall?

Alex

[siennathesane]

I misunderstood why getmac was needed, sorry! Still new to contributing.

[alexbrainman]

I misunderstood why getmac was needed, sorry! Still new to contributing.

No worries.

Alex

[gopherbot]

Change https://golang.org/cl/70845 mentions this issue: [release-branch.go1.8] net: skip Windows test using getmac if getmac cmdlet not available