Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestSetGCPercent flaky #20076

Open
josharian opened this issue Apr 21, 2017 · 2 comments
Open

runtime: TestSetGCPercent flaky #20076

josharian opened this issue Apr 21, 2017 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unplanned

Comments

@josharian
Copy link
Contributor

josharian commented Apr 21, 2017

Despite CL 41374, I'm seeing a bunch of trybot failures like https://storage.googleapis.com/go-build-log/6c83b9bd/linux-amd64_cce08b9e.log:

--- FAIL: TestSetGCPercent (0.17s)
	garbage_test.go:151: NextGC = 172 MB, want 150±20 MB

cc @aclements
@josharian josharian added this to the Go1.9 milestone Apr 21, 2017
@josharian josharian added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 21, 2017
@ALTree
Copy link
Member

ALTree commented Apr 23, 2017

This is failing a lot. Just for reference: I see CL 41374 bumped from ±10 to ±20. Bumping again to ±30 won't help because I've seen failures with 181 (+31).

gopherbot pushed a commit that referenced this issue Apr 24, 2017
@bradfitz
runtime/debug: mark TestSetGCPercent as flaky
6a48019 
Updates #20076

Change-Id: I4eb98abbb49174cc6433e5da2c3660893ef88fd1
Reviewed-on: https://go-review.googlesource.com/41615
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link

gopherbot commented Apr 25, 2017

CL https://golang.org/cl/41615 mentions this issue.

@aclements aclements self-assigned this Jun 7, 2017
@bradfitz bradfitz modified the milestones: Go1.10, Go1.9 Jun 15, 2017
@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 22, 2017
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.10 Nov 22, 2017
@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.11 Jan 3, 2018
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Unplanned Jul 8, 2018
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
7 participants
@bradfitz @josharian @rsc @aclements @ianlancetaylor @ALTree @gopherbot