Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/sys/windows: Some VirtualX syscalls missing #20086

Closed
awnumar opened this issue Apr 23, 2017 · 9 comments
Closed

x/sys/windows: Some VirtualX syscalls missing #20086

awnumar opened this issue Apr 23, 2017 · 9 comments

Comments

@awnumar
Copy link
Contributor

@awnumar awnumar commented Apr 23, 2017

What did you expect to see?

On https://godoc.org/golang.org/x/sys/windows I expected to see the VirtualAlloc and VirtualFree syscalls, and also the VirtualProtect one.

What did you see instead?

Only the VirtualLock and its unlocking counterpart.

These are quite important from a security perspective, are there any plans to have them added?

@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2017
@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Apr 24, 2017

@libeclipse would something like alexbrainman/winapi@c959b37 do?

Alex

@awnumar
Copy link
Contributor Author

@awnumar awnumar commented Apr 24, 2017

@alexbrainman That's a cool little library you have there. Of course it would be nice to have the calls in /x/ eventually, but for now that will do perfectly!

@mxplusb
Copy link

@mxplusb mxplusb commented Jun 4, 2017

@alexbrainman are you going to make those changes into x/sys/windows?

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jun 4, 2017

@alexbrainman are you going to make those changes into x/sys/windows?

I was not planing to.
There is too much code in x/sys/windows as is. I do not want to add even more unless it is useful to many people.
Feel free to copy the code anywhere you like.

Alex

@mxplusb
Copy link

@mxplusb mxplusb commented Jun 4, 2017

Shouldn't x/sys/windows, in theory, contain all the syscalls for Windows, even if they are only marginally used?

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Jun 4, 2017

Shouldn't x/sys/windows, in theory, contain all the syscalls for Windows

No. I think it is impossible to have ALL Windows APIs in x/sys/windows. As you can see (#20086 (comment)), it is very easy do add whatever APIs you desire to your own package.

Alex

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2017

CL https://golang.org/cl/47333 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 30, 2017

CL https://golang.org/cl/47334 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented Jul 1, 2017

CL https://golang.org/cl/47335 mentions this issue.

micanzhang added a commit to micanzhang/sys that referenced this issue Sep 12, 2017
Fixes golang/go#20086

Change-Id: Ifdc2561fe6cc125fa45a57bad9750f3f3f055e66
Reviewed-on: https://go-review.googlesource.com/47335
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@golang golang locked and limited conversation to collaborators Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.