x/sys/windows: Some VirtualX syscalls missing

[awnumar]

What did you expect to see?

On https://godoc.org/golang.org/x/sys/windows I expected to see the VirtualAlloc and VirtualFree syscalls, and also the VirtualProtect one.

What did you see instead?

Only the VirtualLock and its unlocking counterpart.

These are quite important from a security perspective, are there any plans to have them added?

[alexbrainman]

@libeclipse would something like alexbrainman/winapi@c959b37 do?

Alex

[awnumar]

@alexbrainman That's a cool little library you have there. Of course it would be nice to have the calls in /x/ eventually, but for now that will do perfectly!

[siennathesane]

@alexbrainman are you going to make those changes into x/sys/windows?

[alexbrainman]

@alexbrainman are you going to make those changes into x/sys/windows?

I was not planing to.
There is too much code in x/sys/windows as is. I do not want to add even more unless it is useful to many people.
Feel free to copy the code anywhere you like.

Alex

[siennathesane]

Shouldn't x/sys/windows, in theory, contain all the syscalls for Windows, even if they are only marginally used?

[alexbrainman]

Shouldn't x/sys/windows, in theory, contain all the syscalls for Windows

No. I think it is impossible to have ALL Windows APIs in x/sys/windows. As you can see (#20086 (comment)), it is very easy do add whatever APIs you desire to your own package.

Alex

[gopherbot]

CL https://golang.org/cl/47333 mentions this issue.

[gopherbot]

CL https://golang.org/cl/47334 mentions this issue.

[gopherbot]

CL https://golang.org/cl/47335 mentions this issue.