Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: run linux-arm-arm5spacemonkey make.bash cross-compiled on fast machines #20118

Closed
bradfitz opened this issue Apr 25, 2017 · 5 comments
Closed

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Apr 25, 2017

Running make.bash on the ARM5 spacemonkey hardware takes 27 minutes.

We could cross-compile it from Kubernetes like we do for the linux-arm Scaleway trybot builders.

It looks like it's pretty much already set up in coordinator.go,

type crossCompileConfig struct { 
        Buildlet    string 
        CCForTarget string 
        GOARM       string 
} 
 
var crossCompileConfigs = map[string]*crossCompileConfig{ 
        "linux-arm": { 
                Buildlet:    "host-linux-armhf-cross", 
                CCForTarget: "arm-linux-gnueabihf-gcc", 
                GOARM:       "7", 
        }, 
        "linux-arm-arm5spacemonkey": { 
                Buildlet:    "host-linux-armel-cross", 
                CCForTarget: "arm-linux-gnueabi-gcc", 
                GOARM:       "5", 
        }, 
} 
 
func (st *buildStatus) crossCompileMakeAndSnapshot(config *crossCompileConfig) (err error) { 

But this part means it's not being run for non-trybots:

func (st *buildStatus) getCrossCompileConfig() *crossCompileConfig {
        if kubeErr != nil {
                return nil
        }
        if inStaging || st.isTry() {
                return crossCompileConfigs[st.name]
        }
        return nil
}       

/cc @zeebo

@bradfitz bradfitz added the Builders label Apr 25, 2017
@gopherbot gopherbot added this to the Unreleased milestone Apr 25, 2017
@zeebo
Copy link
Contributor

@zeebo zeebo commented Apr 25, 2017

Should we be running for non-trybots? What kind of logic do we want for this?

Let's have it configurable per each cross compiler config and add a OnlyForTry boolean to the config.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Apr 25, 2017

arm5 is way too slow to ever be a trybot. We're only going to be running post-submit builds for this builder type.

@zeebo
Copy link
Contributor

@zeebo zeebo commented Apr 25, 2017

Ok. I'll just remove that condition then and always return a config if it's available and there's no kubernetes error.

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Apr 25, 2017

Oh, sorry, I misread your comment. We don't want to waste resources cross-compiling for linux-arm for post-submit builds, so:

Let's have it configurable per each cross compiler config and add a OnlyForTry boolean to the config.

Yes, that sounds good. Add that bool.

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 25, 2017

CL https://golang.org/cl/41755 mentions this issue.

@golang golang locked and limited conversation to collaborators Apr 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.