Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: make misc-compile-all trybot type check tests too #20119
The "misc-compile-*" Trybot builders try to at least compile & type check every GOOS/GOARCH pair, even when we don't have sufficient hardware to run the tests.
But they apparently don't compile or type check tests.
https://go-review.googlesource.com/c/41691/ broke Plan 9 without any warnings.
Cleanup CL https://golang.org/cl/41691 broke the plan9 build by removing a use of a package but not removing the package import. Trybots don't check that. I filed #20119 for that. Change-Id: Ia030e6924665dfb871ca964455b899d51b0200c2 Reviewed-on: https://go-review.googlesource.com/41752 Reviewed-by: David du Colombier <email@example.com>
The misc builders are defined here:
They use buildall.bash to run: (ignore the typo in docs that says
All that basically does (from a fast linux-amd64 kubernetes container) is:
We'd also need a way to also make buildall.bash run "go test -c $PKG" for each $PKG. That is #15513.
Yeah, I tried just modifying buildall.bash to run