Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: TestClosedPipeRaceWrite fails on ppc64x #20134

Closed
mundaym opened this issue Apr 26, 2017 · 8 comments
Closed

os: TestClosedPipeRaceWrite fails on ppc64x #20134

mundaym opened this issue Apr 26, 2017 · 8 comments

Comments

@mundaym
Copy link
Member

@mundaym mundaym commented Apr 26, 2017

This new test, added in e3d7ec0, seems to have broken the ppc64x builders.

--- FAIL: TestClosedPipeRaceWrite (0.00s)
	pipe_test.go:157: I/O on closed pipe unexpectedly succeeded
FAIL
FAIL	os	0.341s
@mundaym mundaym added this to the Go1.9 milestone Apr 26, 2017
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Apr 26, 2017

@bradfitz bradfitz added the NeedsFix label Apr 26, 2017
@laboger

This comment has been minimized.

Copy link
Contributor

@laboger laboger commented Apr 26, 2017

Kind of odd that this passed the buildbots but fails everywhere else?

@mundaym

This comment has been minimized.

Copy link
Member Author

@mundaym mundaym commented Apr 26, 2017

@laboger I could be wrong but I think the trybots only check that the distribution compiles when targeting ppc64(le?), I don't think they actually run the tests on ppc64x. Does it fail for you locally?

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Apr 26, 2017

Correct. Trybots (pre-submit tests) only compile ppc64x but don't run the tests. Post-submit builds run the tests on ppc64x hardware. We need lots of hardware to support trybots.

@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 27, 2017

What does getconf PIPE_BUF /tmp print on your system?

@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Apr 27, 2017

$ gomote create linux-ppc64-buildlet
user-bradfitz-linux-ppc64-buildlet-0
$ gomote run -system user-bradfitz-linux-ppc64-buildlet-0 getconf PIPE_BUF /tmp
4096

$ gomote create linux-ppc64le-buildlet
user-bradfitz-linux-ppc64le-buildlet-0
$ gomote run -system user-bradfitz-linux-ppc64le-buildlet-0 getconf PIPE_BUF /tmp                                                                                                              
4096
@ianlancetaylor

This comment has been minimized.

Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 27, 2017

OK, that is just weird. This should not be processor dependent.

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Apr 27, 2017

CL https://golang.org/cl/41823 mentions this issue.

@gopherbot gopherbot closed this in 220e0e0 Apr 27, 2017
@golang golang locked and limited conversation to collaborators Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.