You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmd/asm: change canonical spelling of CMOVLEQ to CMOVL.EQ etc #20173
This proposal is originally from @rsc in issue #14069 and is about CMOVLEQ being ambiguous. I Extracted it as I believe it deserves its own issue.
Recounting this to @aclements I figured out what is going on with CMOVLEQ. The GNU form is CMOV[cond][size] but the form added for Go is CMOV[size][cond]. So GNU's cmovleq is cmov-le-q while Go's CMOVLEQ is CMOV-L-EQ. The Intel syntax has no size suffix and is CMOVEQ/CMOVLE, but it seems clear that Go should not be inserting a size suffix in the middle of the defined opcode name. While in general I feel that we need to put up with past mistakes in our assembly definitions to avoid breaking existing assembly programs, this one seems so egregious and error-prone that I think we have no choice but to change these names for Go 1.7 to match the Intel and GNU syntax.
Unfortunately it seems too late for such a breaking change so the proposal evolved into introducing new aliases like CMOVL.EQ (CMOV%size.%cond) to lift the ambiguity and then, later on, remove the old versions. Maybe.
At this point I don't think we can rename instructions like this - it will silently change the meaning of existing (one assumes debugged) code. If we need to do something at all, I would suggest adding CMOVL.EQ as an alias for current Go CMOVLEQ, and so on, and then in a later release removing the dot-free variants.
changed the title [-]Proposal: swap [size] and [cond] in CMOV[size][cond][/-][+]cmd/asm: change canonical spelling of CMOVLEQ to CMOVL.EQ etc[/+]on Jun 12, 2017
Activity
gopherbot commentedon Apr 29, 2017
CL https://golang.org/cl/42092 mentions this issue.
rsc commentedon May 1, 2017
At this point I don't think we can rename instructions like this - it will silently change the meaning of existing (one assumes debugged) code. If we need to do something at all, I would suggest adding CMOVL.EQ as an alias for current Go CMOVLEQ, and so on, and then in a later release removing the dot-free variants.
[-]Proposal: swap [size] and [cond] in CMOV[size][cond][/-][+]cmd/asm: change canonical spelling of CMOVLEQ to CMOVL.EQ etc[/+]rsc commentedon Jun 12, 2017
No one replied to previous comment (but two thumbs up) so I'm repurposing for that "clearer new spelling" instead of "change existing meaning" fix.
dlespiau commentedon Jun 15, 2017
Yes, thank you for renaming the issue. Updated the proposal text accordingly as well.
gopherbot commentedon Sep 27, 2017
Change https://golang.org/cl/66451 mentions this issue:
cmd/asm: add CMOVL.EQ->CMOVLEQ aliasquasilyte commentedon May 18, 2018
Should this be done for 1.11?
Suffixes are used for AVX-512 things, should we reconsider
CMOVL.EQor add additional suffixes for these? (see #22779)gopherbot commentedon Apr 13, 2019
Change https://golang.org/cl/171732 mentions this issue:
cmd/internal/obj/x86: permit new CMOVL syntax with suffix