net/http: connReader.bgErr is read but never set #20196
Closed
Comments
Haven't looked into it, but I assume we should just delete unused things. |
CL https://golang.org/cl/42370 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
bgErr
inconnReader
(server.go
line 626) is read in line 735, but it's never assigned to.Do we want to write to it in the
handleReadError
method, or should we get rid of the field and the dead code? (I assume the former, but opening an issue just in case)Found via https://github.com/mvdan/unparam, which noticed that the
handleReadError
is unused.CC @bradfitz
The text was updated successfully, but these errors were encountered: