Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: connReader.bgErr is read but never set #20196

Closed
mvdan opened this issue May 1, 2017 · 2 comments
Closed

net/http: connReader.bgErr is read but never set #20196

mvdan opened this issue May 1, 2017 · 2 comments
Assignees
@paranoiacblack
Labels
FrozenDueToAge NeedsFix
Milestone
Go1.9

Comments

@mvdan
Copy link
Member

@mvdan mvdan commented May 1, 2017 •
edited

bgErr in connReader (server.go line 626) is read in line 735, but it's never assigned to.

Do we want to write to it in the handleReadError method, or should we get rid of the field and the dead code? (I assume the former, but opening an issue just in case)

Found via https://github.com/mvdan/unparam, which noticed that the handleReadError is unused.

CC @bradfitz
@bradfitz bradfitz added this to the Go1.9 milestone May 1, 2017
@bradfitz bradfitz added the NeedsFix label May 1, 2017
@bradfitz

This comment has been minimized.

Sign in to view
Copy link
Contributor

@bradfitz bradfitz commented May 1, 2017

Haven't looked into it, but I assume we should just delete unused things.
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented May 2, 2017

CL https://golang.org/cl/42370 mentions this issue.
@paranoiacblack paranoiacblack self-assigned this May 2, 2017
@gopherbot gopherbot closed this in 48def43 May 2, 2017
@golang golang locked and limited conversation to collaborators May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paranoiacblack paranoiacblack

Labels
FrozenDueToAge NeedsFix
Projects
None yet
Milestone
  Go1.9
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@mvdan @bradfitz @gopherbot @paranoiacblack
You can’t perform that action at this time.