New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: missing line numbers with cgo pragmas #20214

Open
josharian opened this Issue May 2, 2017 · 0 comments

Comments

Projects
None yet
3 participants
@josharian
Contributor

josharian commented May 2, 2017

Reproduce: go install -race cmd/compile, compilebench -run=SSA -cpuprofile=c, go tool pprof -lines $(go tool -n compile) c.

Result: entries like __tsan_read :-134217728. That's no filename, line number underflow. Ideally it'd refer to the place where the symbol was defined. We have the position information as we enter pragcgo in the compiler, but it never gets recorded in pragcgobuf. Not sure how much work would be required to thread it through from there.

@josharian josharian added this to the Go1.10 milestone May 2, 2017

@mdempsky mdempsky modified the milestones: Go1.10, Go1.11 Nov 30, 2017

@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jun 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment