Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: don't run racecompiler builder if commit doesn't include -c change #20222

Closed
bradfitz opened this issue May 3, 2017 · 8 comments
Closed
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 3, 2017

We shouldn't run the racecompiler builder if the commit being tested isn't a descendent of 22f1b56

(Noticed from a Go 1.8 release branch trybot failure: https://go-review.googlesource.com/c/42532/ failed with: https://storage.googleapis.com/go-build-log/c8c86992/linux-amd64-racecompile_6fb68b46.log)

/cc @josharian @kardianos

@bradfitz bradfitz self-assigned this May 3, 2017
@gopherbot gopherbot added this to the Unreleased milestone May 3, 2017
@gopherbot gopherbot added the Builders label May 3, 2017
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented May 3, 2017

(The issue adding the racecompile builder was #19962)

@bradfitz bradfitz changed the title x/build: don't run racecompiler builder if commit doesn't include x/build: don't run racecompiler builder if commit doesn't include -c change May 3, 2017
@josharian
Copy link
Contributor

@josharian josharian commented May 5, 2017

You can use git merge-base --is-ancestor. merge-base docs: https://git-scm.com/docs/git-merge-base

@gopherbot
Copy link

@gopherbot gopherbot commented May 16, 2017

CL https://golang.org/cl/43554 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue May 16, 2017
maintnerd will have an API to query this in a subsequent CL.

Updates golang/go#20222

Change-Id: I3cb0ce2897eea782f627c2e27c4d02ef0eb6c66b
Reviewed-on: https://go-review.googlesource.com/43554
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 16, 2017

CL https://golang.org/cl/43555 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue May 17, 2017
Fix a stupid bug fortunately found before production.

Add the test that caught it.

Updates golang/go#20222

Change-Id: Ie988d80dec18e5d0fede7a31e3b6cce62b050f5f
Reviewed-on: https://go-review.googlesource.com/43555
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
@gopherbot
Copy link

@gopherbot gopherbot commented May 17, 2017

CL https://golang.org/cl/43557 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue May 17, 2017
For upcoming API development, permit running maintnerd in non-syncing
(no new mutations logged) mode, using only the data from the godata
package.

Updates golang/go#19866
Updates golang/go#20222

Change-Id: I8c66c7f5e29b5702b481da0fec8f270f93f484a9
Reviewed-on: https://go-review.googlesource.com/43557
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 17, 2017

CL https://golang.org/cl/43560 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue May 18, 2017
Also, update docs on how to re-generate.
Switches to using go4.org/grpc and go4.org/grpc-codegen/protoc-gen-go4grpc
for now.

Updates golang/go#19866
Updates golang/go#20222

Change-Id: Ifa8a123fca2a30f17270c3c558b7395a02064eae
Reviewed-on: https://go-review.googlesource.com/43560
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented May 18, 2017

CL https://golang.org/cl/43619 mentions this issue.

@gopherbot
Copy link

@gopherbot gopherbot commented May 18, 2017

CL https://golang.org/cl/43620 mentions this issue.

@golang golang locked and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.