Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upx/build: don't run racecompiler builder if commit doesn't include -c change #20222
Comments
This comment has been minimized.
This comment has been minimized.
|
(The issue adding the racecompile builder was #19962) |
bradfitz
changed the title
This comment has been minimized.
This comment has been minimized.
|
You can use |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43554 mentions this issue. |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 16, 2017
maintnerd will have an API to query this in a subsequent CL. Updates golang/go#20222 Change-Id: I3cb0ce2897eea782f627c2e27c4d02ef0eb6c66b Reviewed-on: https://go-review.googlesource.com/43554 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43555 mentions this issue. |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 17, 2017
Fix a stupid bug fortunately found before production. Add the test that caught it. Updates golang/go#20222 Change-Id: Ie988d80dec18e5d0fede7a31e3b6cce62b050f5f Reviewed-on: https://go-review.googlesource.com/43555 Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43557 mentions this issue. |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 17, 2017
For upcoming API development, permit running maintnerd in non-syncing (no new mutations logged) mode, using only the data from the godata package. Updates golang/go#19866 Updates golang/go#20222 Change-Id: I8c66c7f5e29b5702b481da0fec8f270f93f484a9 Reviewed-on: https://go-review.googlesource.com/43557 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43560 mentions this issue. |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
May 18, 2017
Also, update docs on how to re-generate. Switches to using go4.org/grpc and go4.org/grpc-codegen/protoc-gen-go4grpc for now. Updates golang/go#19866 Updates golang/go#20222 Change-Id: Ifa8a123fca2a30f17270c3c558b7395a02064eae Reviewed-on: https://go-review.googlesource.com/43560 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43619 mentions this issue. |
This comment has been minimized.
This comment has been minimized.
|
CL https://golang.org/cl/43620 mentions this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We shouldn't run the racecompiler builder if the commit being tested isn't a descendent of 22f1b56
(Noticed from a Go 1.8 release branch trybot failure: https://go-review.googlesource.com/c/42532/ failed with: https://storage.googleapis.com/go-build-log/c8c86992/linux-amd64-racecompile_6fb68b46.log)
/cc @josharian @kardianos