Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch #20226

Closed
mwhudson opened this issue May 3, 2017 · 4 comments
Closed

cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch #20226

mwhudson opened this issue May 3, 2017 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.8.5

Comments

@mwhudson
Copy link
Contributor

mwhudson commented May 3, 2017 •
edited by bradfitz

Backport golang.org/cl/41821 to 1.8 branch

This fixes an issue with shared libraries / plugins on 386.

(Hope I'm doing this right)
@mwhudson mwhudson added this to the Go1.8.2 milestone May 3, 2017
@bradfitz bradfitz modified the milestones: Go1.8.2, Go1.8.3 May 18, 2017
@bradfitz bradfitz changed the title backport golang.org/cl/41821 to 1.8 branch cmd/internal/obj/x86: backport "cmd/internal/obj/x86: use LEAx rather than ADDx" to 1.8 branch May 19, 2017
@bradfitz
Copy link
Contributor

I don't think this qualifies for a Go 1.8 backport.

a) there wasn't even a bug for https://golang.org/cl/41821
b) and it was never declared whether this was a regression from Go 1.7.
c) there was never a test

Feel free to disagree.

/cc @broady

@bradfitz bradfitz modified the milestones: Unplanned, Go1.8.3 May 23, 2017
@mwhudson
Copy link
Contributor Author

I didn't file a bug because I found the fix before I got around to filing the bug. It is a regression from 1.7. It is an issue that I don't know how to write a test.

(I've been on leave, hence the late reply).

@mwhudson mwhudson reopened this May 31, 2017
@mwhudson mwhudson modified the milestones: Go1.8.4, Unplanned May 31, 2017
@rsc rsc modified the milestones: Go1.8.4, Go1.8.5 Oct 4, 2017
@rsc
Copy link
Contributor

rsc commented Oct 13, 2017 •
edited

There really should be a bug and a test but I trust the CL since it went through the Go 1.9 release process.

CL 41821 OK for Go 1.8.5.
CL 70871 OK for Go 1.8.5. (Fixed merge problems in CL 41821.)

@rsc rsc added release-blocker CherryPickApproved Used during the release process for point releases and removed release-blocker labels Oct 13, 2017
@rsc rsc mentioned this issue Oct 14, 2017
Closed
@rsc
Copy link
Contributor

rsc commented Oct 26, 2017

go1.8.5 has been packaged and includes:

The release is posted at golang.org/dl.

— golang.org/x/build/cmd/releasebot, Oct 26 21:07:48 UTC

@rsc rsc closed this as completed Oct 26, 2017
@golang golang locked and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.8.5
Development

No branches or pull requests
4 participants
@bradfitz @rsc @mwhudson @gopherbot