Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: inconsistent/not idiomatic spelling of GitHub in two identifiers #20236

2 tasks done
dmitshur opened this issue May 4, 2017 · 1 comment
2 tasks done
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge


Copy link

dmitshur commented May 4, 2017

This is a minor issue. It's also trivial to fix if a minor breaking API change is acceptable (IIRC x/build API is not yet stable, please correct if wrong). It's easier to resolve this sooner rather than later, before it has more users.

Most of the identifiers use "GitHub" or "github" (unexported version) spelling, which is correct and consistent:

  • type GitHub
  • type GitHubUser
  • type GitHubIssue
  • type GitHubLabel
  • type GitHubMilestone
  • type GitHubComment
  • type GitHubIssueEvent
  • type GitHubIssueRef

But 2 identifiers use "Github", which is neither:

  • type GithubRepoID
  • func (*Corpus) TrackGithub

They should be renamed to use "GitHub", if possible.



/cc @bradfitz

@gopherbot gopherbot added this to the Unreleased milestone May 4, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 4, 2017
@kevinburke kevinburke self-assigned this May 7, 2017
Copy link

Change mentions this issue: maintner: rename TrackGithub to TrackGitHub

@golang golang locked and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
None yet

No branches or pull requests

3 participants