Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build: stop using Early and Maybe milestones, update tools to early-in-cycle, release-blocker #20252
Currently Go use 3 different GitHub Milestones for each Go release.
@spf13, @campoy and I would like to eliminate the "Early" and "Maybe" milestones and only keep the "Go1.9" style one. The information conveyed by the "Early" and "Maybe" parts will be converted into new labels (names TBD).
The meaning of the current milestones is not widely known by people outside the few people who use them:
Note that "Early" doesn't mean high priority and is not mutually exclusive with "Maybe". We've had a number of bugs kicked along from e.g. Go1.8Early to Go1.9Early to Go1.10Early. It only means it's must land early if it does.
This bug is about figuring out the label names.
The obvious choices are for label names are "Early" and "Maybe", but given people's confusion in the past, and because adding "Maybe" to somebody's bug feels and looks a big rude, we thought we'd open up the discussion for alternative names.
Some possibilities for Maybe:
Ideas welcome. (But note that it's an explicit non-goal of this bug to revamp all our labels right now. Let's limit proposals to just these two, but you can keep future labels in mind.)
The connotations here probably mean there'd be a lot fewer "regular" (Blocks-Release) issues, since Blocks-Release sounds intimidating, but that probably reflects reality better anyway.
I like the approach of marking things the release needs vs things that can be bumped. Maybe "first-month". It's much more clear the the alternatives IMO. "release-critical" or "release-blocker" both sound good to me. I'll see what other projects use. Perhaps there's a perfect label out there.…
On Fri, May 5, 2017 at 11:48 AM Josh Bleecher Snyder < ***@***.***> wrote: I dunno. No one says labels need to be short. "High-Risk"? "First-Month-Of-Cycle"? "Needs-Soak"? "Early-Freeze"? Blah. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20252 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKlZAAHl52Ob29mNIRqOuQl0wjFlizbks5r20TggaJpZM4NRe94> .
"early-only" doesn't necessarily imply high risk, though. It often means that it's a massive refactoring and doing it even 2 months after the dev window opens means that you would cause rebase hell for other people's in-flight changes. So certain large changes (even trivial low-risk changes) we pre-schedule to be landed within the first week of the tree opening.
So I'd like to avoid talking about risk.
I'm neutral on whether we make that change but if we're going to do it, I'd slightly prefer starting these labels in the lowercase style rather than having to convert them later also.
Alternatively, we go all lowercase first.
@spf13, did you still want to do that? Do others feel strongly either way?