Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: stopping X11 application makes it unresponsive #20256

Closed
veger opened this issue May 5, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@veger
Copy link

commented May 5, 2017

What version of Go are you using (go version)?

go version go1.7.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/user/go"
GORACE=""
GOROOT="/usr/lib/go-1.7"
GOTOOLDIR="/usr/lib/go-1.7/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build582626726=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?

I started the mobile/basic example using Ubuntu, so the X11 driver is used.
When closing it, the application does not get the StageDead lifecycle event and is not stopped completely.

What did you expect to see?

That the application is properly stopped

What did you see instead?

The paint events stop, making the application unresponsive.

@gopherbot

This comment has been minimized.

Copy link

commented May 5, 2017

CL https://golang.org/cl/42811 mentions this issue.

@bradfitz bradfitz changed the title Stopping X11 application makes it unresponsive x/mobile: stopping X11 application makes it unresponsive May 5, 2017

@gopherbot gopherbot added this to the Unreleased milestone May 5, 2017

veger added a commit to veger/mobile that referenced this issue May 6, 2017

Fix hang when (X11) application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
@veger

This comment has been minimized.

Copy link
Author

commented Jun 5, 2017

It has been a month since I submitted this issue, and provided a PR to fix it, is there something else I need to be doing in order to get it accepted?

veger added a commit to veger/mobile that referenced this issue Jun 9, 2017

Fix hang when (X11) application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

@bradfitz bradfitz added the mobile label Jul 20, 2017

pankona added a commit to pankona/mobile that referenced this issue Aug 4, 2017

Fix hang when (X11) application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

pankona added a commit to pankona/mobile that referenced this issue Aug 9, 2017

Fix hang when (X11) application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

veger added a commit to veger/mobile that referenced this issue Aug 28, 2018

app:fix hang when application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

veger added a commit to veger/mobile that referenced this issue Aug 28, 2018

Fix hang when (X11) application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

veger added a commit to veger/mobile that referenced this issue Aug 28, 2018

app: fix hang when application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

veger added a commit to veger/mobile that referenced this issue Aug 28, 2018

app: fix hang when application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760

veger added a commit to veger/mobile that referenced this issue Aug 28, 2018

app: fix hang when application is closed
Events are Send() after the pump is being stopped (src is not read any more).
This blocks a critical go routine, resulting in the application not properly being stopped.

By continue reading the src channel during shutting down the pump, the block is removed and the application is able to stop.

Fixes golang/go#20256

Change-Id: I1536e8697cd4a0e504e7359e48acce04088e5760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.