New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: pass values to some convT2Exxx #20263

Open
josharian opened this Issue May 5, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@josharian
Contributor

josharian commented May 5, 2017

For example, the signature of convT2Estring is:

func convT2Estring(t *_type, elem unsafe.Pointer) (e eface)

We could change it to:

func convT2Estring(t *_type, s string) (e eface)

This would increase the size of the call site, but it would also means that the argument doesn't have to be made addressable and might not have its address taken, which probably increases other optimization opportunities (e.g. can be SSA'd and registerized). And there'd be a call site size decrease for (say) convT2E16.

We should try this out and see whether the impact makes it worth doing.

@josharian josharian added this to the Go1.10 milestone May 5, 2017

@bradfitz bradfitz modified the milestones: Go1.10, Go1.11 Nov 28, 2017

@bradfitz bradfitz modified the milestones: Go1.11, Unplanned May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment