Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/internal/obj/x86: add ADDSUBPS/PD #20293

Closed
dlespiau opened this issue May 9, 2017 · 2 comments
Closed

cmd/internal/obj/x86: add ADDSUBPS/PD #20293

dlespiau opened this issue May 9, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@dlespiau
Copy link
Contributor

dlespiau commented May 9, 2017 •
edited

I'm going through extensions 1 by 1 fixing little things here and there, this time it's SSE3 turn. Only a couple of instructions were missing: ADDSUBPS and ADDSUBPD.

While finding what's missing or not tested is automated, generation of the Optab entries isn't (yet!).

$ x86db-gogen list --extension SSE3 --not-known
ADDSUBPD xmmreg,xmmrm [rm: 66 0f d0 /r] PRESCOTT,SSE3,SO
ADDSUBPS xmmreg,xmmrm [rm: f2 0f d0 /r] PRESCOTT,SSE3,SO
@gopherbot
Copy link

CL https://golang.org/cl/42990 mentions this issue.

@bradfitz bradfitz added this to the Go1.10 milestone May 9, 2017
@quasilyte
Copy link
Contributor

quasilyte commented Sep 17, 2017 •
edited

Is there a reason CL42990 is not merged yet?
With this one on board, I believe whole SSE will be complete [with the exceptions of some MMX instructions].
CC @TocarIP

@golang golang locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@bradfitz @dlespiau @quasilyte @gopherbot