Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: field tracking is broken again #20316

Closed
dsnet opened this issue May 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@dsnet
Copy link
Member

commented May 10, 2017

Previously broke in #20014

Field tracking is broken again by https://go-review.googlesource.com/40864

The failure can be reproduced by running this test tool: https://godoc.org/rsc.io/tmp/fieldtrack

/cc @josharian

@dsnet dsnet added the NeedsFix label May 10, 2017

@dsnet dsnet added this to the Go1.9 milestone May 10, 2017

@dsnet

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

We really need the builders to test this... :/
\cc @bradfitz

@gopherbot

This comment has been minimized.

Copy link

commented May 10, 2017

CL https://golang.org/cl/43151 mentions this issue.

@gopherbot gopherbot closed this in 201fd16 May 10, 2017

@dsnet

This comment has been minimized.

Copy link
Member Author

commented May 10, 2017

@ianlancetaylor and @mdempsky suggested making this a compiler flag so that we dont need to rebuild the entire toolchain just test this. Would be significant step into making this tested by the builders.

@golang golang locked and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.