Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: remove Allsym traversal for fieldtrack #20318

Closed
josharian opened this issue May 10, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@josharian
Copy link
Contributor

commented May 10, 2017

cmd/link/internal/ld/go.go func fieldtrack does a full traversal of Allsym, which we'd like to generally remove (#14624). It is only going to find any symbols to process when the fieldtrack GOEXPERIMENT is enabled; let's avoid calling it entirely unless field tracking is enabled in the toolchain.

@josharian josharian added this to the Go1.10 milestone May 10, 2017

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017

@gopherbot

This comment has been minimized.

Copy link

commented May 17, 2018

Change https://golang.org/cl/113635 mentions this issue: cmd/link/internal/ld: don't call fieldtrack if it's not enabled

@gopherbot gopherbot closed this in 8bb3913 May 17, 2018

@golang golang locked and limited conversation to collaborators May 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.