Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: most trybots don't run gdb tests; add newer gdb #20382

Closed
cherrymui opened this issue May 16, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@cherrymui
Copy link
Contributor

commented May 16, 2017

Tried CL https://go-review.googlesource.com/c/42670/ to see whether trybots have gdb on them. It turns out that most of the Linux and BSD trybots have gdb that is too old. gdb test is only run on linux-arm trybot. This may make people confusing when the test fails, where people may think the failure is specific to ARM. I think we should run gdb tests on most, if not all, Linux and BSD builders.

@cherrymui cherrymui added this to the Unreleased milestone May 16, 2017

@bradfitz bradfitz changed the title builder: most trybots don't run gdb tests x/build: most trybots don't run gdb tests; add newer gdb May 16, 2017

@gopherbot gopherbot added the Builders label May 16, 2017

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 16, 2017

linux-amd64 (to pick the first failure there, and the most important) is:

https://github.com/golang/build/blob/master/env/linux-x86-std-kube/Dockerfile

Which is:

FROM debian:wheezy

https://packages.debian.org/wheezy/gdb -- 7.4.1

We should upgrade to jessie, the current stable:

https://packages.debian.org/jessie/gdb -- 7.7.1

Which would pass:

    if major < 7 || (major == 7 && minor < 7) {
        t.Fatalf("skipping: gdb version %d.%d too old", major, minor)
    }

/cc @jessfraz

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 16, 2017

But whoever does this Jessie upgrade (Jessie?) should make sure that any other Docker images using linux-x86-std-kube as their base still build.

@jessfraz

This comment has been minimized.

Copy link
Contributor

commented May 17, 2017

@gopherbot

This comment has been minimized.

Copy link

commented May 17, 2017

CL https://golang.org/cl/43535 mentions this issue.

gopherbot pushed a commit to golang/build that referenced this issue May 17, 2017

env: change linux-x86-std-kube to debian jessie
Updates golang/go#20382

Change-Id: I87ac8f53278f1624232b3239e61b60cc2ee341ca
Reviewed-on: https://go-review.googlesource.com/43535
Reviewed-by: Sarah Adams <shadams@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

This comment has been minimized.

Copy link
Member

commented May 17, 2017

I've updated the Linux images, so this is done... enough. Windows and FreeBSD are too tricky to be worth it.

@bradfitz bradfitz closed this May 17, 2017

@golang golang locked and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.