Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/asn1: parsing issues w/ x509 #20430

Closed
kumarde opened this issue May 19, 2017 · 2 comments
Closed

encoding/asn1: parsing issues w/ x509 #20430

kumarde opened this issue May 19, 2017 · 2 comments

Comments

@kumarde
Copy link

@kumarde kumarde commented May 19, 2017

What version of Go are you using (go version)?

1.8.1

What operating system and processor architecture are you using (go env)?

amd64, OSX

What did you do?

We are pulling a bunch of certs from CT logs, and occasionally run into the following ASN1 parse error (in the worst case, ~10% of the certificates from skydiver exhibit this problem)

asn1: structure error: tags don't match (16 vs {class:2 tag:0 length:3 isCompound:true}) {optional:false explicit:false application:false defaultValue:<nil> tag:<nil> stringType:0 timeType:0 set:false omitEmpty:false} tbsCertificate @2 <nil>

You can replicate this issue here: https://play.golang.org/p/IL-Ey-fSXt

What did you expect to see?

We expect these classes of certs to parse correctly. After all, they come from CT!

What did you see instead?

Parse errors :(

Does anyone have any thoughts?

@kumarde kumarde changed the title ASN1 parsing issues w/ x509 encoding/asn1 parsing issues w/ x509 May 19, 2017
@bradfitz bradfitz changed the title encoding/asn1 parsing issues w/ x509 encoding/asn1: parsing issues w/ x509 May 19, 2017
@bradfitz bradfitz added this to the Go1.10 milestone May 19, 2017
@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented May 19, 2017

/cc @agl

@kumarde
Copy link
Author

@kumarde kumarde commented May 20, 2017

Sorry, I figured this one out. Thanks!

@kumarde kumarde closed this May 20, 2017
@golang golang locked and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.